Skip to content

Commit

Permalink
Address latest round of comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
aomarks committed Dec 19, 2017
1 parent 0ebfc24 commit 7b581de
Show file tree
Hide file tree
Showing 23 changed files with 2,722 additions and 1,787 deletions.
2 changes: 1 addition & 1 deletion externs/closure-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,7 @@ Polymer_LegacyElementMixin.prototype.getEffectiveChildren = function(){};
Polymer_LegacyElementMixin.prototype.getEffectiveTextContent = function(){};
/**
* @param {string} selector Selector to run.
* @return {Object.<Node>}
* @return {Node}
*/
Polymer_LegacyElementMixin.prototype.queryEffectiveChildren = function(selector){};
/**
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ gulp.task('generate-typescript', async () => {
});

gulp.task('update-version', () => {
gulp.src('lib/utils/boot.html')
return gulp.src('lib/utils/boot.html')
.pipe(replace(/(window.Polymer.version = )'\d+\.\d+\.\d+'/, `$1'${require('./package.json').version}'`))
.pipe(gulp.dest('lib/utils'));
});
2 changes: 1 addition & 1 deletion lib/legacy/legacy-element-mixin.html
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
* match `selector`. These can be dom child nodes or elements distributed
* to children that are insertion points.
* @param {string} selector Selector to run.
* @return {Object<Node>} First effective child node that matches selector.
* @return {Node} First effective child node that matches selector.
*/
queryEffectiveChildren(selector) {
let e$ = this.queryDistributedElements(selector);
Expand Down
7 changes: 2 additions & 5 deletions lib/utils/debounce.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
(function() {
'use strict';

/** @typedef {{run: function(function(), number=):number, cancel: function(number)}} */
let AsyncModule; // eslint-disable-line no-unused-vars

/**
* @summary Collapse multiple callbacks into one invocation after a timer.
* @memberof Polymer
Expand All @@ -33,7 +30,7 @@
* a callback and optional arguments to be passed to the run function
* from the async module.
*
* @param {!AsyncModule} asyncModule Object with Async interface.
* @param {!AsyncInterface} asyncModule Object with Async interface.
* @param {function()} callback Callback to run.
* @return {void}
*/
Expand Down Expand Up @@ -101,7 +98,7 @@
* the debouncer has completed.
*
* @param {Debouncer?} debouncer Debouncer object.
* @param {!AsyncModule} asyncModule Object with Async interface
* @param {!AsyncInterface} asyncModule Object with Async interface
* @param {function()} callback Callback to run.
* @return {!Debouncer} Returns a debouncer object.
*/
Expand Down
4 changes: 2 additions & 2 deletions lib/utils/html-tag.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
* static get partialTemplate() { return Polymer.html`<span>Partial!</span>`; }
*
* @memberof Polymer
* @param {ITemplateArray} strings Constant parts of tagged template literal
* @param {!ITemplateArray} strings Constant parts of tagged template literal
* @param {...*} values Variable parts of tagged template literal
* @return {!HTMLTemplateElement} Constructed HTMLTemplateElement
*/
Expand All @@ -61,4 +61,4 @@
return template;
};
})();
</script>
</script>
Loading

0 comments on commit 7b581de

Please sign in to comment.