From 7b0c57a43ee815c9a8c8e32333d9e99b95834733 Mon Sep 17 00:00:00 2001 From: Steven Orvell Date: Wed, 18 Dec 2019 18:45:43 -0800 Subject: [PATCH] Lint fixes. --- lib/legacy/class.js | 2 +- lib/utils/settings.js | 8 ++++---- test/unit/legacy-noattributes.html | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/legacy/class.js b/lib/legacy/class.js index dc03f8e15d..08234ff41f 100644 --- a/lib/legacy/class.js +++ b/lib/legacy/class.js @@ -304,7 +304,7 @@ function GenerateClassFromInfo(info, Base, behaviors) { const a = this.attributes; for (let i=0, l=a.length; i < l; i++) { const attr = a[i]; - this.__attributeReaction(attr.name, undefined, attr.value) + this.__attributeReaction(attr.name, undefined, attr.value); } } super.created(); diff --git a/lib/utils/settings.js b/lib/utils/settings.js index 13d7634eaf..0d3fcd85d8 100644 --- a/lib/utils/settings.js +++ b/lib/utils/settings.js @@ -316,7 +316,7 @@ export const setSuppressTemplateNotifications = function(suppress) { /** * Setting to disable use of dynamic attributes. This is an optimization * to avoid setting `observedAttributes`. Instead attributes are read - * once at create time. + * once at create time and set/removeAttribute are patched. */ export let legacyNoObservedAttributes = window.Polymer && window.Polymer.legacyNoObservedAttributes || false; @@ -324,9 +324,9 @@ export let legacyNoObservedAttributes = /** * Sets `legacyNoObservedAttributes` globally, to disable `observedAttributes`. * - * @param {boolean} disables `observedAttributes` + * @param {boolean} noObservedAttributes enable or disable `legacyNoObservedAttributes` * @return {void} */ -export const setLegacyNoObservedAttributes = function(noAttributes) { - legacyNoObservedAttributes = noAttributes; +export const setLegacyNoObservedAttributes = function(noObservedAttributes) { + legacyNoObservedAttributes = noObservedAttributes; }; \ No newline at end of file diff --git a/test/unit/legacy-noattributes.html b/test/unit/legacy-noattributes.html index 848769c798..d44a347518 100644 --- a/test/unit/legacy-noattributes.html +++ b/test/unit/legacy-noattributes.html @@ -77,8 +77,6 @@ import {flush} from '../../lib/utils/flush.js'; import {wrap} from '../../lib/utils/wrap.js'; - let el = window.configured; - suite('legacyNoObservedAttributes', () => { let el;