Lint fixes.

Polymer · Dec 19, 2019 · 7b0c57a · 7b0c57a
1 parent 8ef2cc7
commit 7b0c57a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/lib/legacy/class.js b/lib/legacy/class.js
@@ -304,7 +304,7 @@ function GenerateClassFromInfo(info, Base, behaviors) {
         const a = this.attributes;
         for (let i=0, l=a.length; i < l; i++) {
           const attr = a[i];
-          this.__attributeReaction(attr.name, undefined, attr.value)
+          this.__attributeReaction(attr.name, undefined, attr.value);
         }
       }
       super.created();

diff --git a/lib/utils/settings.js b/lib/utils/settings.js
@@ -316,17 +316,17 @@ export const setSuppressTemplateNotifications = function(suppress) {
 /**
  * Setting to disable use of dynamic attributes. This is an optimization
  * to avoid setting `observedAttributes`. Instead attributes are read
- * once at create time.
+ * once at create time and set/removeAttribute are patched.
  */
 export let legacyNoObservedAttributes =
   window.Polymer && window.Polymer.legacyNoObservedAttributes || false;
 
 /**
  * Sets `legacyNoObservedAttributes` globally, to disable `observedAttributes`.
  *
- * @param {boolean} disables `observedAttributes`
+ * @param {boolean} noObservedAttributes enable or disable `legacyNoObservedAttributes`
  * @return {void}
  */
-export const setLegacyNoObservedAttributes = function(noAttributes) {
-  legacyNoObservedAttributes = noAttributes;
+export const setLegacyNoObservedAttributes = function(noObservedAttributes) {
+  legacyNoObservedAttributes = noObservedAttributes;
 };
diff --git a/test/unit/legacy-noattributes.html b/test/unit/legacy-noattributes.html
@@ -77,8 +77,6 @@
     import {flush} from '../../lib/utils/flush.js';
     import {wrap} from '../../lib/utils/wrap.js';
 
-    let el = window.configured;
-
     suite('legacyNoObservedAttributes', () => {
 
       let el;