Skip to content

Commit

Permalink
Make event notification handler read the value from currentTarget,
Browse files Browse the repository at this point in the history
instead of target which may not be bound to any data.

Fixes #5308
  • Loading branch information
tomalec committed Jul 30, 2018
1 parent d59546d commit 7a00b3c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/mixins/property-effects.html
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@
toPath = Polymer.Path.translate(fromProp, toPath, fromPath);
value = detail && detail.value;
} else {
value = event.target[fromProp];
value = event.currentTarget[fromProp];
}
value = negate ? !value : value;
if (!inst[TYPES.READ_ONLY] || !inst[TYPES.READ_ONLY][toPath]) {
Expand Down
10 changes: 10 additions & 0 deletions test/unit/property-effects.html
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,16 @@
assert.equal(el.observerCounts.customEventValueChanged, 1, 'custom bound property observer not called');
});

test('custom notification bubbling event to property', function() {
const child = document.createElement('div');
el.$.boundChild.appendChild(child);

el.$.boundChild.customEventValue = 42;
child.dispatchEvent(new Event('custom', {bubbles: true}));
assert.equal(el.customEventValue, 42, 'custom bound property incorrect');
assert.equal(el.observerCounts.customEventValueChanged, 1, 'custom bound property observer not called');
});

test('custom notification event to path', function() {
el.clearObserverCounts();
el.$.boundChild.customEventObjectValue = 84;
Expand Down

0 comments on commit 7a00b3c

Please sign in to comment.