Skip to content

Commit

Permalink
[ci skip] Update comment to include reference to problem browser.
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinpschaaf committed Feb 22, 2017
1 parent a0ad3bb commit 72f21fe
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions src/standard/configure.html
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,14 @@
this._configureProperties(this.behaviors[i].properties, config);
}
// prototypical behavior
// Read `properties` off of the prototype, as an concession to non-spec
// compliant browsers where a.) HTMLElement's have a non-spec `properties`
// property, and b.) the `properties` accessor is on instances rather
// than `HTMLElement.prototype`; going under the instance to the prototype
// avoids the problem.
// Read `properties` off of the prototype, as a concession to non-spec
// compliant browsers (e.g. Android UC Browser 11.2.0.915) where
// a.) HTMLElement's have a non-spec `properties` property, and
// b.) the `properties` accessor is on instances rather than
// `HTMLElement.prototype`; going under the instance to the prototype
// avoids the problem. Note can't always go to __proto__ due to IE10
// hence conditional, but IE10 doesn't suffer from the instance properties
// issue (happy coincidence of browser quirks).
this._configureProperties(avoidInstanceProperties ?
this.__proto__.properties : this.properties, config);
// TODO(sorvell): it *may* be faster to loop over _propertyInfo but
Expand Down

0 comments on commit 72f21fe

Please sign in to comment.