Merge pull request #5348 from Polymer/sync-externs

Upstream changes to externs
Polymer · Feb 5, 2019 · 6611abe · 6611abe
2 parents 77ac3ec + 19dd467
commit 6611abe
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/externs/webcomponents-externs.js b/externs/webcomponents-externs.js
@@ -12,23 +12,37 @@
  */
 /* eslint-disable */
 
-let ShadyDOM = {
+var HTMLImports = {
+  /**
+   * @param {function()} callback
+   */
+  whenReady(callback) {},
+  /**
+   * @param {Element} element
+   * @returns {Document} document
+   */
+  importForElement(element) {}
+};
+
+window.HTMLImports = HTMLImports;
+
+var ShadyDOM = {
   inUse: false,
-  flush(){},
+  flush() {},
   /**
    * @param {!Node} target
    * @param {function(Array<MutationRecord>, MutationObserver)} callback
    * @return {MutationObserver}
    */
-  observeChildren(target, callback){},
+  observeChildren(target, callback) {},
   /**
    * @param {MutationObserver} observer
    */
-  unobserveChildren(observer){},
+  unobserveChildren(observer) {},
   /**
    * @param {Node} node
    */
-  patch(node){}
+  patch(node) {}
 };
 
 window.ShadyDOM = ShadyDOM;

diff --git a/lib/legacy/legacy-data-mixin.js b/lib/legacy/legacy-data-mixin.js
@@ -41,7 +41,7 @@ function wrapEffect(effect, fnName) {
         fn.apply(this, arguments);
       } catch (e) {
         if (e instanceof UndefinedArgumentError) {
-          console.warn(`Argument '${e.arg}'${fnName ?` for method '${fnName}'` : ''} was undefined. Ensure it has an undefined check.`);
+          console.warn(`Argument '${e.arg}'${fnName ?` for method '${fnName}'` : ''} was undefined. Ensure it has a default value, or else ensure the method handles the argument being undefined.`);
         } else {
           throw e;
         }