Merge pull request #1589 from Polymer/1491-1578-kschaaf

Clear input.value attribute before removing for IE. Fixes #1491. Fixe…

src/lib/annotations/annotations.html

@@ -187,9 +187,6 @@
     // add annotation data from attributes to the `annotation` for node `node`
     // TODO(sjmiles): the distinction between an `annotation` and
     // `annotation data` is not as clear as it could be
-    // Walk attributes backwards, since removeAttribute can be vetoed by
-    // IE in certain cases (e.g. <input value="foo">), resulting in the
-    // attribute staying in the attributes list
     _parseNodeAttributeAnnotations: function(node, annotation) {
       for (var i=node.attributes.length-1, a; (a=node.attributes[i]); i--) {
         var n = a.name, v = a.value;
@@ -244,6 +241,13 @@
           v = v.substring(0, colon);
           customEvent = true;
         }
+        // Clear attribute before removing, since IE won't allow removing
+        // `value` attribute if it previously had a value (can't
+        // unconditionally set '' before removing since attributes with `$`
+        // can't be set using setAttribute)
+        if (node.localName == 'input' && n == 'value') {
+          node.setAttribute(n, '');
+        }
         // Remove annotation
         node.removeAttribute(n);
         // Case hackery: attributes are lower-case, but bind targets

test/unit/bind-elements.html

@@ -25,6 +25,7 @@
     <span id="boundText">{{text}}</span>
     <span idtest id="{{boundId}}"></span>
     <s id="computedContent">{{computeFromTrickyLiterals(3, 'tricky\,\'zot\'')}}</s>
+    <input id="boundInput" value="{{text::input}}">
 </template>
 <script>
   Polymer({

test/unit/bind.html

@@ -32,6 +32,10 @@
     document.body.removeChild(el);
   });
 
+  test('undefined input value', function() {
+    assert.equal(el.$.boundInput.value, '', 'undefined input value not blank');
+  });
+
   test('id is bindable', function() {
     assert.equal(Polymer.dom(el.root).querySelector('span[idtest]').id, 'span', 'id bound to <span> not found');
   });