Skip to content

Commit

Permalink
Update types.
Browse files Browse the repository at this point in the history
  • Loading branch information
rictic committed Mar 30, 2018
1 parent f78b051 commit 5357d64
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
8 changes: 5 additions & 3 deletions externs/closure-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ Polymer_PropertiesChanged.prototype._shouldPropertyChange = function(property, v
* @param {string} name Name of attribute that changed
* @param {?string} old Old attribute value
* @param {?string} value New attribute value
* @param {?string} namespace Attribute namespace.
* @return {void}
*/
Polymer_PropertiesChanged.prototype.attributeChangedCallback = function(name, old, value){};
Polymer_PropertiesChanged.prototype.attributeChangedCallback = function(name, old, value, namespace){};
/**
* @param {string} attribute Name of attribute to deserialize.
* @param {?string} value of the attribute.
Expand Down Expand Up @@ -972,9 +973,10 @@ Polymer_LegacyElementMixin.prototype._initializeProperties = function(){};
* @param {string} name Name of attribute.
* @param {?string} old Old value of attribute.
* @param {?string} value Current value of attribute.
* @param {?string} namespace Attribute namespace.
* @return {void}
*/
Polymer_LegacyElementMixin.prototype.attributeChangedCallback = function(name, old, value){};
Polymer_LegacyElementMixin.prototype.attributeChangedCallback = function(name, old, value, namespace){};
/**
* @override
* @return {void}
Expand Down Expand Up @@ -1391,7 +1393,7 @@ Polymer_DisableUpgradeMixin.prototype._enableProperties = function(){};
/**
* @override
*/
Polymer_DisableUpgradeMixin.prototype.attributeChangedCallback = function(name, old, value){};
Polymer_DisableUpgradeMixin.prototype.attributeChangedCallback = function(name, old, value, namespace){};
/**
* @override
*/
Expand Down
3 changes: 2 additions & 1 deletion types/lib/elements/dom-module.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ declare namespace Polymer {
* @param name Name of attribute.
* @param old Old value of attribute.
* @param value Current value of attribute.
* @param namespace Attribute namespace.
*/
attributeChangedCallback(name: string, old: string|null, value: string|null): void;
attributeChangedCallback(name: string, old: string|null, value: string|null, namespace: string|null): void;

/**
* Registers the dom-module at a given id. This method should only be called
Expand Down
3 changes: 2 additions & 1 deletion types/lib/legacy/legacy-element-mixin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ declare namespace Polymer {
* @param name Name of attribute.
* @param old Old value of attribute.
* @param value Current value of attribute.
* @param namespace Attribute namespace.
*/
attributeChangedCallback(name: string, old: string|null, value: string|null): void;
attributeChangedCallback(name: string, old: string|null, value: string|null, namespace: string|null): void;

/**
* Provides an implementation of `connectedCallback`
Expand Down
2 changes: 1 addition & 1 deletion types/lib/mixins/disable-upgrade-mixin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ declare namespace Polymer {
interface DisableUpgradeMixin {
_initializeProperties(): void;
_enableProperties(): void;
attributeChangedCallback(name: any, old: any, value: any): void;
attributeChangedCallback(name: any, old: any, value: any, namespace: any): void;
connectedCallback(): void;
disconnectedCallback(): void;
}
Expand Down
3 changes: 2 additions & 1 deletion types/lib/mixins/properties-changed.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,9 @@ declare namespace Polymer {
* @param name Name of attribute that changed
* @param old Old attribute value
* @param value New attribute value
* @param namespace Attribute namespace.
*/
attributeChangedCallback(name: string, old: string|null, value: string|null): void;
attributeChangedCallback(name: string, old: string|null, value: string|null, namespace: string|null): void;

/**
* Deserializes an attribute to its associated property.
Expand Down

0 comments on commit 5357d64

Please sign in to comment.