From bbaaf72768324079e58fd62807879fc5e74d0478 Mon Sep 17 00:00:00 2001 From: Daniel Freedman Date: Mon, 25 Jun 2018 15:03:25 -0700 Subject: [PATCH 1/3] Port Closure Compiler fixes to polymer-externs --- externs/polymer-externs.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/externs/polymer-externs.js b/externs/polymer-externs.js index 0a86620b69..c3b7cdfaaa 100644 --- a/externs/polymer-externs.js +++ b/externs/polymer-externs.js @@ -109,4 +109,15 @@ Polymer.version; * @extends {HTMLElement} * @implements {Polymer_LegacyElementMixin} */ -var PolymerElement = Polymer.LegacyElementMixin(); +var PolymerElement = function() {}; + +/** On create callback. */ +PolymerElement.prototype.created = function() {}; +/** On ready callback. */ +PolymerElement.prototype.ready = function() {}; +/** On registered callback. */ +PolymerElement.prototype.registered = function() {}; +/** On attached to the DOM callback. */ +PolymerElement.prototype.attached = function() {}; +/** On detached from the DOM callback. */ +PolymerElement.prototype.detached = function() {}; From bcd01b96c0ef539408aaf8a023bfcec46daaffa1 Mon Sep 17 00:00:00 2001 From: Daniel Freedman Date: Mon, 25 Jun 2018 15:05:58 -0700 Subject: [PATCH 2/3] port other fixes as well --- externs/polymer-externs.js | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/externs/polymer-externs.js b/externs/polymer-externs.js index c3b7cdfaaa..c47d9a7a06 100644 --- a/externs/polymer-externs.js +++ b/externs/polymer-externs.js @@ -15,19 +15,19 @@ /** * @typedef {{ - * type: !Function, - * value: *, - * readOnly: (boolean | undefined), - * computed: (string | undefined), - * reflectToAttribute: (boolean | undefined), - * notify: (boolean | undefined), - * observer: (string | function(*,*) | undefined) + * type: !Function, + * value: (* | undefined), + * readOnly: (boolean | undefined), + * computed: (string | undefined), + * reflectToAttribute: (boolean | undefined), + * notify: (boolean | undefined), + * observer: (string | function(this:?, ?, ?) | undefined) * }} */ let PolymerElementPropertiesMeta; /** - * @typedef {Object} + * @typedef {Object} */ let PolymerElementProperties; @@ -69,9 +69,6 @@ PropertiesMixinConstructor.properties; */ function Polymer(init){} -/** @type {PolymerElementProperties} */ -Polymer.ElementProperties; - /** * @type {(function(*,string,string,Node):*)|undefined} */ @@ -120,4 +117,4 @@ PolymerElement.prototype.registered = function() {}; /** On attached to the DOM callback. */ PolymerElement.prototype.attached = function() {}; /** On detached from the DOM callback. */ -PolymerElement.prototype.detached = function() {}; +PolymerElement.prototype.detached = function() {}; \ No newline at end of file From 805122018b0cafcbb93ae07d4435324b54d3068d Mon Sep 17 00:00:00 2001 From: Daniel Freedman Date: Mon, 25 Jun 2018 15:26:28 -0700 Subject: [PATCH 3/3] split chrome and firefox runs, maybe fewer timeouts for firefox --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 475a17ebbd..39da32bd9c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,8 @@ before_script: '\n\033[31mERROR:\033[0m Typings are stale. Please run "npm run update-types".' && false) script: -- wct -l chrome -l firefox +- wct -l chrome +- wct -l firefox - if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then travis_wait 30 ./util/travis-sauce-test.sh; fi env: global: