Merge pull request #5270 from Polymer/2.x-merge-closure-fixes

Port Closure Compiler fixes to polymer-externs

.travis.yml

@@ -17,7 +17,8 @@ before_script:
   '\n\033[31mERROR:\033[0m Typings are stale. Please run "npm run
   update-types".' && false)
 script:
-- wct -l chrome -l firefox
+- wct -l chrome
+- wct -l firefox
 - if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then travis_wait 30 ./util/travis-sauce-test.sh; fi
 env:
   global:

externs/polymer-externs.js

@@ -15,19 +15,19 @@
 
 /**
  * @typedef {{
- * type: !Function,
- * value: *,
- * readOnly: (boolean | undefined),
- * computed: (string | undefined),
- * reflectToAttribute: (boolean | undefined),
- * notify: (boolean | undefined),
- * observer: (string | function(*,*) | undefined)
+ *   type: !Function,
+ *   value: (* | undefined),
+ *   readOnly: (boolean | undefined),
+ *   computed: (string | undefined),
+ *   reflectToAttribute: (boolean | undefined),
+ *   notify: (boolean | undefined),
+ *   observer: (string | function(this:?, ?, ?) | undefined)
  * }}
  */
 let PolymerElementPropertiesMeta;
 
 /**
- * @typedef {Object<string, !PolymerElementPropertiesMeta>}
+ * @typedef {Object<string, !Function|!PolymerElementPropertiesMeta>}
  */
 let PolymerElementProperties;
 
@@ -69,9 +69,6 @@ PropertiesMixinConstructor.properties;
  */
 function Polymer(init){}
 
-/** @type {PolymerElementProperties} */
-Polymer.ElementProperties;
-
 /**
  * @type {(function(*,string,string,Node):*)|undefined}
  */
@@ -109,4 +106,15 @@ Polymer.version;
  * @extends {HTMLElement}
  * @implements {Polymer_LegacyElementMixin}
  */
-var PolymerElement = Polymer.LegacyElementMixin();
+var PolymerElement = function() {};
+
+/** On create callback. */
+PolymerElement.prototype.created = function() {};
+/** On ready callback. */
+PolymerElement.prototype.ready = function() {};
+/** On registered callback. */
+PolymerElement.prototype.registered = function() {};
+/** On attached to the DOM callback. */
+PolymerElement.prototype.attached = function() {};
+/** On detached from the DOM callback. */
+PolymerElement.prototype.detached = function() {};