From 4cc6c339218a1d66be69e9f764383f3cc6de8205 Mon Sep 17 00:00:00 2001
From: Alexander Marks <aomarks@google.com>
Date: Thu, 30 May 2019 15:38:35 -0700
Subject: [PATCH] Align signatures of attributeChangedCallback

---
 lib/elements/dom-bind.js            | 6 +++++-
 lib/mixins/disable-upgrade-mixin.js | 4 ++--
 lib/mixins/properties-changed.js    | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/elements/dom-bind.js b/lib/elements/dom-bind.js
index cc9b4f70ba..a897a92ab8 100644
--- a/lib/elements/dom-bind.js
+++ b/lib/elements/dom-bind.js
@@ -64,9 +64,13 @@ export class DomBind extends domBindBase {
 
   /**
    * @override
+   * @param {string} name Name of attribute that changed
+   * @param {?string} old Old attribute value
+   * @param {?string} value New attribute value
+   * @param {?string} namespace Attribute namespace.
    * @return {void}
    */
-  attributeChangedCallback() {
+  attributeChangedCallback(name, old, value, namespace) {
     // assumes only one observed attribute
     this.mutableData = true;
   }
diff --git a/lib/mixins/disable-upgrade-mixin.js b/lib/mixins/disable-upgrade-mixin.js
index a97aa9e9ba..7cb9e894fa 100644
--- a/lib/mixins/disable-upgrade-mixin.js
+++ b/lib/mixins/disable-upgrade-mixin.js
@@ -67,8 +67,8 @@ export const DisableUpgradeMixin = dedupingMixin((base) => {
      * @param {string} name Attribute name.
      * @param {?string} old The previous value for the attribute.
      * @param {?string} value The new value for the attribute.
-     * @param {?string=} namespace The XML namespace for the attribute.
-     * @return {undefined}
+     * @param {?string} namespace The XML namespace for the attribute.
+     * @return {void}
      */
     attributeChangedCallback(name, old, value, namespace) {
       if (name == DISABLED_ATTR) {
diff --git a/lib/mixins/properties-changed.js b/lib/mixins/properties-changed.js
index 8b71c46c62..363138b1ac 100644
--- a/lib/mixins/properties-changed.js
+++ b/lib/mixins/properties-changed.js
@@ -426,7 +426,7 @@ export const PropertiesChanged = dedupingMixin(
      * @param {string} name Name of attribute that changed
      * @param {?string} old Old attribute value
      * @param {?string} value New attribute value
-     * @param {?string=} namespace Attribute namespace.
+     * @param {?string} namespace Attribute namespace.
      * @return {void}
      * @suppress {missingProperties} Super may or may not implement the callback
      * @override