diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9e28b18040..2ce36c0ad0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -42,7 +42,7 @@ If you find an issue, please do file it on the repository. The [Polymer/polymer For issues with elements the team maintains, please file directly on the element's repository. If you're not sure if a bug stems from the element or the library, air toward filing it on the element and we'll move the issue if necessary. -Please file issues using the issue template provided, filling out as many fields as possible. We love examples for addressing issues - issues with a Plunkr, jsFiddle, or jsBin will be much easier for us to work on quickly. You can start with [this jsbin](http://jsbin.com/luhaxab/1/edit) which sets up the basics to demonstrate a Polymer element. +Please file issues using the issue template provided, filling out as many fields as possible. We love examples for addressing issues - issues with a Plunkr, jsFiddle, or jsBin will be much easier for us to work on quickly. You can start with [this jsbin](http://jsbin.com/luhaxab/edit) which sets up the basics to demonstrate a Polymer element. Occasionally we'll close issues if they appear stale or are too vague - please don't take this personally! Please feel free to re-open issues we've closed if there's something we've missed and they still need to be addressed. diff --git a/lib/legacy/legacy-element-mixin.html b/lib/legacy/legacy-element-mixin.html index bcf6922da1..ffb86dd6a6 100644 --- a/lib/legacy/legacy-element-mixin.html +++ b/lib/legacy/legacy-element-mixin.html @@ -456,7 +456,7 @@ * are not automatically handled. For example, * a user should call `distributeContent` if distribution has been * invalidated due to an element being added or removed from the shadowRoot - * that contains an insertion point () inside its subtree. + * that contains an insertion point (``) inside its subtree. */ distributeContent() { if (window.ShadyDOM) { diff --git a/lib/mixins/element-mixin.html b/lib/mixins/element-mixin.html index 20dbb6f474..8e38ed1b2e 100644 --- a/lib/mixins/element-mixin.html +++ b/lib/mixins/element-mixin.html @@ -124,8 +124,6 @@ let caseMap = Polymer.CaseMap; - const DISABLED = 'disable-upgrade'; - /** * Returns the `properties` object specifically on `klass`. Use for: * (1) super chain mixes togther to make `propertiesForClass` which is @@ -453,8 +451,6 @@ proto._bindTemplate(template); } - function flushPropertiesStub() {} - /** * @polymerMixinClass * @unrestricted @@ -472,7 +468,7 @@ */ static get observedAttributes() { if (!this.hasOwnProperty(JSCompiler_renameProperty('__observedAttributes', this))) { - let list = [DISABLED]; + let list = []; let properties = propertiesForClass(this); for (let prop in properties) { list.push(Polymer.CaseMap.camelToDashCase(prop)); @@ -723,19 +719,7 @@ * @override */ attributeChangedCallback(name, old, value) { - // process `disable-upgrade` specially: - // First we see `disable-upgrade` added and disable `_flushProperties`, - // then when it's removed, restore regular flushing and flush. - // This should only be allowed before "readying". - if (name === DISABLED && !this.__dataInitialized) { - if (value !== null) { - this.__flushProperties = this._flushProperties; - this._flushProperties = flushPropertiesStub; - } else { - this._flushProperties = this.__flushProperties; - this._flushProperties(); - } - } else if (old !== value) { + if (old !== value) { let property = caseMap.dashToCamelCase(name); let type = propertiesForClass(this.constructor)[property].type; if (!this._hasReadOnlyEffect(property)) { diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html index 41ae03d0f6..5a54aea543 100644 --- a/lib/mixins/property-effects.html +++ b/lib/mixins/property-effects.html @@ -605,7 +605,7 @@ /** * Returns true if a binding's metadata meets all the requirements to allow - * 2-way binding, and therefore a -changed event listener should be + * 2-way binding, and therefore a `-changed` event listener should be * added: * - used curly braces * - is a property (not attribute) binding @@ -1316,7 +1316,7 @@ * * The implementation makes a best-effort at binding interop: * Some native element properties have side-effects when - * re-setting the same value (e.g. setting .value resets the + * re-setting the same value (e.g. setting `.value` resets the * cursor position), so we do a dirty-check before setting the value. * However, for better interop with non-Polymer custom elements that * accept objects, we explicitly re-set object changes coming from the diff --git a/lib/mixins/template-stamp.html b/lib/mixins/template-stamp.html index 6bafd2d484..fee06c90a2 100644 --- a/lib/mixins/template-stamp.html +++ b/lib/mixins/template-stamp.html @@ -118,11 +118,6 @@ */ class TemplateStamp extends superClass { - constructor() { - super(); - this.$ = null; - } - /** * Scans a template to produce template metadata. * @@ -136,43 +131,46 @@ * The template metadata object returned from this method has the following * structure (many fields optional): * + * ```js * { * // Flattened list of node metadata (for nodes that generated metadata) * nodeInfoList: [ * { * // `id` attribute for any nodes with id's for generating `$` map - * id: '', + * id: {string}, * // `on-event="handler"` metadata * events: [ * { - * name: '' - * value: '' + * name: {string}, // event name + * value: {string}, // handler method name * }, ... * ], * // Notes when the template contained a `` for shady DOM * // optimization purposes - * hasInsertionPoint: , - * // For nested