Skip to content

Commit

Permalink
Merge pull request #5612 from Polymer/legacy-undefined-noBatch-sync
Browse files Browse the repository at this point in the history
Merge from master.
  • Loading branch information
Steve Orvell authored Jan 10, 2020
2 parents 8b7df16 + 943905f commit 4464cca
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Code owners for Polymer
* @sorvell @kevinpschaaf @TimvdLippe @azakus
* @sorvell @kevinpschaaf @azakus
31 changes: 31 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,36 @@
# Change Log

## [v3.3.1](https://github.com/Polymer/polymer/tree/v3.3.1) (2019-11-08)
- [ci skip] bump to 3.3.1 ([commit](https://github.com/Polymer/polymer/commit/11f1f139))

- Remove TimvdLippe from CODEOWNERS ([commit](https://github.com/Polymer/polymer/commit/b99c2997))

- Add node field to PolymerDomApi ([commit](https://github.com/Polymer/polymer/commit/15747c83))

- Improve types for the template field on Polymer elements. (#5596) ([commit](https://github.com/Polymer/polymer/commit/4274bcec))

- Add module field ([commit](https://github.com/Polymer/polymer/commit/9a4d4d9a))

- Wrap other `hasOwnProperty` checks in `JSCompiler_renameProperty`. ([commit](https://github.com/Polymer/polymer/commit/0541b21a))

- Wrap `hasOwnProperty` checks for `__hasRegisterFinished` in `JSCompiler_renameProperty()`. ([commit](https://github.com/Polymer/polymer/commit/9e90fd2e))

- Fix typing error in fixPlaceholder ([commit](https://github.com/Polymer/polymer/commit/f050ce9e))

- Fix up comments based on feedback ([commit](https://github.com/Polymer/polymer/commit/ab49f51a))

- Workaround bindings to textarea.placeholder in IE ([commit](https://github.com/Polymer/polymer/commit/61767da2))

- Add additional externs (#5575) ([commit](https://github.com/Polymer/polymer/commit/69ee4688))

- Make Closure compiler happier about ShadyDOM access ([commit](https://github.com/Polymer/polymer/commit/46ee2aec))

- Remove other double import (#5565) ([commit](https://github.com/Polymer/polymer/commit/0d2c2e5d))

- Only use CONST_CASE for constants. (#5564) ([commit](https://github.com/Polymer/polymer/commit/54f8b47f))

- [skip ci] update changelog ([commit](https://github.com/Polymer/polymer/commit/ac12b3bc))

## [v3.3.0](https://github.com/Polymer/polymer/tree/v3.3.0) (2019-06-24)
- [ci skip] Update version to 3.3.0 ([commit](https://github.com/Polymer/polymer/commit/dd7c0d70))

Expand Down
5 changes: 4 additions & 1 deletion externs/polymer-dom-api-externs.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*
* @interface
*/
var PolymerDomApi = function() {};
let PolymerDomApi = function() {};

/**
* @param {?Node} node
Expand Down Expand Up @@ -103,6 +103,9 @@ PolymerDomApi.prototype.getDestinationInsertionPoints = function() {};
/** @return {?Node} */
PolymerDomApi.prototype.getOwnerRoot = function() {};

/** @type {!Node} */
PolymerDomApi.prototype.node;

/**
* @param {string} attribute
* @param {string} value
Expand Down
6 changes: 3 additions & 3 deletions externs/polymer-externs.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ PolymerInit.prototype.extends;
PolymerInit.prototype.properties;
/** @type {(!Array<string> | undefined)} */
PolymerInit.prototype.observers;
/** @type {(!HTMLTemplateElement | string | undefined)} */
/** @type {(!HTMLTemplateElement | string | undefined | null)} */
PolymerInit.prototype.template;
/** @type {(!Object<string, *> | undefined)} */
PolymerInit.prototype.hostAttributes;
Expand All @@ -60,7 +60,7 @@ PolymerElementConstructor.extends;
PolymerElementConstructor.properties;
/** @type {(!Array<string> | undefined)} */
PolymerElementConstructor.observers;
/** @type {(!HTMLTemplateElement | string | undefined)} */
/** @type {(!HTMLTemplateElement | string | undefined | null)} */
PolymerElementConstructor.template;

/** @interface */
Expand Down Expand Up @@ -174,7 +174,7 @@ var PolymerElement = function() {};
PolymerElement.is;
/**
* The template to stamp when creating this element type.
* @type {!HTMLTemplateElement|undefined}
* @type {!HTMLTemplateElement|undefined|null}
*/
PolymerElement.template;
/**
Expand Down
2 changes: 1 addition & 1 deletion lib/elements/dom-bind.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export class DomBind extends domBindBase {
render() {
let template;
if (!this.__children) {
template = /** @type {HTMLTemplateElement} */(template || this.querySelector('template'));
template = /** @type {?HTMLTemplateElement} */(template || this.querySelector('template'));
if (!template) {
// Wait until childList changes and template should be there by then
let observer = new MutationObserver(() => {
Expand Down
2 changes: 1 addition & 1 deletion lib/legacy/polymer.dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const matchesSelector = function(node, selector) {
class DomApiNative {

/**
* @param {Node} node Node for which to create a Polymer.dom helper object.
* @param {!Node} node Node for which to create a Polymer.dom helper object.
*/
constructor(node) {
if (window['ShadyDOM'] && window['ShadyDOM']['inUse']) {
Expand Down
2 changes: 1 addition & 1 deletion lib/mixins/element-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { wrap } from '../utils/wrap.js';
* Current Polymer version in Semver notation.
* @type {string} Semver notation of the current version of Polymer.
*/
export const version = '3.3.0';
export const version = '3.3.1';

export const builtCSS = window.ShadyCSS && window.ShadyCSS['cssBuild'];

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"name": "@polymer/polymer",
"version": "3.3.0",
"version": "3.3.1",
"description": "The Polymer library makes it easy to create your own web components. Give your element some markup and properties, and then use it on a site. Polymer provides features like dynamic templates and data binding to reduce the amount of boilerplate you need to write",
"main": "polymer-element.js",
"module": "polymer-element.js",
"directories": {
"doc": "docs",
"test": "test"
Expand Down

0 comments on commit 4464cca

Please sign in to comment.