From 42dd361f942fb57b700d2dac7b97bb49491aa0d9 Mon Sep 17 00:00:00 2001 From: Kevin Schaaf Date: Thu, 7 Mar 2019 18:12:26 -0800 Subject: [PATCH] Fix closure issues --- externs/polymer-externs.js | 3 +++ lib/mixins/property-effects.js | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/externs/polymer-externs.js b/externs/polymer-externs.js index 16fe1eaf33..a45439ae94 100644 --- a/externs/polymer-externs.js +++ b/externs/polymer-externs.js @@ -147,6 +147,9 @@ Polymer.legacyWarnings; /** @type {boolean} */ Polymer.legacyNotifyOrder; +/** @type {boolean} */ +Polymer.orderedComputed; + // nb. This is explicitly 'var', as Closure Compiler checks that this is the case. /** * @constructor diff --git a/lib/mixins/property-effects.js b/lib/mixins/property-effects.js index 11b6ced9dc..de2d153cb4 100644 --- a/lib/mixins/property-effects.js +++ b/lib/mixins/property-effects.js @@ -553,9 +553,10 @@ function propertyIsDirty(inst, trigger, changedProps, hasPaths) { } } }); + return false; } else { - return changedProps && trigger.rootProperty in changedProps || - inst.__dataPending && trigger.rootProperty in inst.__dataPending; + return Boolean(changedProps && trigger.rootProperty in changedProps || + inst.__dataPending && trigger.rootProperty in inst.__dataPending); } }