Fix closure issues

Polymer · Mar 8, 2019 · 42dd361 · 42dd361
1 parent 810a70f
commit 42dd361
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/externs/polymer-externs.js b/externs/polymer-externs.js
@@ -147,6 +147,9 @@ Polymer.legacyWarnings;
 /** @type {boolean} */
 Polymer.legacyNotifyOrder;
 
+/** @type {boolean} */
+Polymer.orderedComputed;
+
 // nb. This is explicitly 'var', as Closure Compiler checks that this is the case.
 /**
  * @constructor

diff --git a/lib/mixins/property-effects.js b/lib/mixins/property-effects.js
@@ -553,9 +553,10 @@ function propertyIsDirty(inst, trigger, changedProps, hasPaths) {
         }
       }
     });
+    return false;
   } else {
-    return changedProps && trigger.rootProperty in changedProps ||
-          inst.__dataPending && trigger.rootProperty in inst.__dataPending;
+    return Boolean(changedProps && trigger.rootProperty in changedProps ||
+      inst.__dataPending && trigger.rootProperty in inst.__dataPending);
   }
 }