Skip to content

Commit

Permalink
Avoid _setPendingProperty warning due to types not understanding dedu…
Browse files Browse the repository at this point in the history
…ping mixin.
  • Loading branch information
kevinpschaaf committed Dec 8, 2017
1 parent a12934c commit 40d47f2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion externs/closure-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ Polymer_PropertiesChanged.prototype._getProperty = function(property){};
/**
* @param {string} property Name of the property
* @param {*} value Value to set
* @param {boolean=} ext Not used here; affordance for closure
* @return {boolean}
*/
Polymer_PropertiesChanged.prototype._setPendingProperty = function(property, value){};
Polymer_PropertiesChanged.prototype._setPendingProperty = function(property, value, ext){};
/**
* @return {undefined}
*/
Expand Down
3 changes: 2 additions & 1 deletion lib/mixins/properties-changed.html
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,11 @@
*
* @param {string} property Name of the property
* @param {*} value Value to set
* @param {boolean=} ext Not used here; affordance for closure
* @return {boolean} Returns true if the property changed
* @protected
*/
_setPendingProperty(property, value) {
_setPendingProperty(property, value, ext) {
let old = this.__data[property];
let changed = this._shouldPropertyChange(property, value, old);
if (changed) {
Expand Down

0 comments on commit 40d47f2

Please sign in to comment.