In _notifyListener, only use e.detail if the event has a detail. …

…This is necessary for `::eventName` compatibility where `eventName` is a native event like `change`.
Polymer · Nov 10, 2015 · 3ece552 · 3ece552
1 parent 139257b
commit 3ece552
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/standard/configure.html b/src/standard/configure.html
@@ -179,8 +179,11 @@
     // handling is queue/defered until then.
     _notifyListener: function(fn, e) {
       if (!Polymer.Bind._isEventBogus(e, e.target)) {
-        var value = e.detail.value;
-        var path = e.detail.path;
+        var value, path;
+        if (e.detail) {
+          value = e.detail.value;
+          path = e.detail.path;
+        }
         if (!this._clientsReadied) {
           this._queueHandler([fn, e.target, value, path]);
         } else {

diff --git a/test/unit/bind.html b/test/unit/bind.html
@@ -257,7 +257,7 @@
   test('custom notification event to path', function() {
     el.clearObserverCounts();
     el.$.boundChild.customEventObjectValue = 84;
-    el.fire('change', null, {node: el.$.boundChild});
+    el.$.boundChild.dispatchEvent(new Event('change'));
     assert.equal(el.customEventObject.value, 84, 'custom bound path incorrect');
     assert.equal(el.observerCounts.customEventObjectValueChanged, 1, 'custom bound path observer not called');
   });