Skip to content

Commit

Permalink
Merge pull request #5099 from Polymer/misc-typescript
Browse files Browse the repository at this point in the history
Tighten a type. Bump TS generator version. Format Travis type error.
  • Loading branch information
TimvdLippe authored Feb 7, 2018
2 parents 9b3ca2c + c58f3e0 commit 2e39cf6
Show file tree
Hide file tree
Showing 8 changed files with 106 additions and 23 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ before_script:
- npm install -g bower gulp-cli@1
- bower install
- gulp lint-eslint
- gulp update-types
- git diff --exit-code
- >-
npm run update-types && git diff --exit-code || (echo -e
'\n\033[31mERROR:\033[0m Typings are stale. Please run "npm run
update-types".' && false)
script:
- wct -l chrome -l firefox
- if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then travis_wait 30 ./util/travis-sauce-test.sh; fi
Expand Down
2 changes: 1 addition & 1 deletion gen-tsd.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"excludeFiles": [
"dist/**",
"externs/**",
"gulpfile.js",
Expand Down
2 changes: 1 addition & 1 deletion lib/legacy/polymer.dom.html
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@

/**
* Returns the `composedPath` for this event.
* @return {!Array<EventTarget>} The nodes this event propagated through
* @return {!Array<!EventTarget>} The nodes this event propagated through
*/
get path() {
return this.event.composedPath();
Expand Down
109 changes: 92 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@polymer/gen-closure-declarations": "^0.4.0",
"@polymer/gen-typescript-declarations": "^0.3.6",
"@polymer/gen-typescript-declarations": "^1.1.1",
"@webcomponents/shadycss": "^1.1.0",
"@webcomponents/webcomponentsjs": "^1.1.0",
"babel-preset-minify": "^0.2.0",
Expand Down
4 changes: 4 additions & 0 deletions types/lib/legacy/mutable-data-behavior.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ declare namespace Polymer {
_shouldPropertyChange(property: string, value: any, old: any): boolean;
}

const MutableDataBehavior: object;

/**
* Legacy element behavior to add the optional ability to skip strict
* dirty-checking for objects and arrays (always consider them to be
Expand Down Expand Up @@ -128,4 +130,6 @@ declare namespace Polymer {
*/
_shouldPropertyChange(property: string, value: any, old: any): boolean;
}

const OptionalMutableDataBehavior: object;
}
2 changes: 1 addition & 1 deletion types/lib/legacy/polymer.dom.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,5 @@ declare class EventApi {
/**
* Returns the `composedPath` for this event.
*/
readonly path: Array<EventTarget|null>;
readonly path: EventTarget[];
}
2 changes: 2 additions & 0 deletions types/lib/legacy/templatizer-behavior.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,6 @@ declare namespace Polymer {
*/
modelForElement(el: HTMLElement|null): TemplateInstanceBase|null;
}

const Templatizer: object;
}

0 comments on commit 2e39cf6

Please sign in to comment.