Skip to content

Commit

Permalink
Modernize the build
Browse files Browse the repository at this point in the history
  • Loading branch information
dfreedm committed Dec 15, 2015
1 parent 82b2443 commit 2b69bb1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
language: node_js
sudo: false
node_js: 4
node_js: stable

This comment has been minimized.

Copy link
@samccone

samccone Dec 15, 2015

Contributor

just fyi to cover 60%~ of node users you should shoot for

0.12, 4, 5

to bump up to ~90%

adding 0.10 is required

This comment has been minimized.

Copy link
@dfreedm

dfreedm Dec 15, 2015

Author Member

Not sure how that matters, polymer doesn't need to be testing on multiple versions of node.

This comment has been minimized.

Copy link
@samccone

samccone Dec 15, 2015

Contributor

it only matters from a standpoint of easier contributions (from the community). If that is not part of the equation then it does not matter.

the above ^ more or less a PSA around node usage statistics

addons:
firefox: latest
sauce_connect: true
apt:
sources:
- google-chrome
- ubuntu-toolchain-r-test
packages:
- google-chrome-stable
- g++-4.8
before_script:
- npm install bower
- export PATH=$PWD/node_modules/.bin:$PATH
- npm install -g bower
- bower install
script:
- xvfb-run wct
Expand All @@ -19,3 +21,4 @@ env:
global:
- secure: eFrp9xwSYG579rAR9/XyXYKh+UtIQJ1xS5q5PABu4ndYFckdJb8o3m7oXqRSikbiPWbCSd3Fkd6+ZKXlcQFdjJ+nx9gFitGthtH93qkvZCO3XhWEEBPj65igIo3hrRSOB6dIWyiZcnoH9IXLLQtKXY9uL1NCqCcyVHg1omPKr9w=
- secure: EAjjkzqZ8z+PEvdo2N2MiIjkqUYAjVkQABKyMw6N4hUa6YSNEW9PYyn4I0d9Rdvc25GwJ+oLQFdeQepioAkNfp6wYUj2IdMIfmmKa1aJWo5DWvOMDYp3ufRhIoiVi4ZVpLg9sTjw+078UhUQFWE44rwfUtHiIb2UbWe2/ueLOiM=
- CXX=g++-4.8
2 changes: 1 addition & 1 deletion test/unit/globals.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

// Polymer
Polymer: true,
currentImport: true
currentImport: true,

// weird safari + selenium globals
alert: true,
Expand Down

0 comments on commit 2b69bb1

Please sign in to comment.