Fix for scoping when class is not specified on element (null was prep…

…ended instead of empty string)
Polymer · Feb 4, 2016 · 24e9fc7 · 24e9fc7
1 parent 4a9ef8e
commit 24e9fc7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/standard/x-styling.html b/src/standard/x-styling.html
@@ -215,7 +215,7 @@
 
       _scopeElementClass: function(element, selector) {
         if (!nativeShadow && !this._scopeCssViaAttr) {
-          selector += (selector ? ' ' : '') + SCOPE_NAME + ' ' + this.is +
+          selector = (selector ? selector + ' ' : '') + SCOPE_NAME + ' ' + this.is +
             (element._scopeSelector ? ' ' +  XSCOPE_NAME + ' ' +
             element._scopeSelector : '');
         }

diff --git a/test/unit/styling-scoped-elements.html b/test/unit/styling-scoped-elements.html
@@ -442,3 +442,12 @@
     is: 'x-overriding'
   });
 </script>
+
+<script>
+  Polymer({
+    is: 'x-scope-no-class',
+    ready: function() {
+      this.scopeSubtree(this, true);
+    }
+  });
+</script>
diff --git a/test/unit/styling-scoped.html b/test/unit/styling-scoped.html
@@ -51,6 +51,10 @@
   </div>
   <x-overriding></x-overriding>
 
+  <x-scope-no-class>
+    <div></div>
+  </x-scope-no-class>
+
 <script>
   suite('scoped-styling', function() {
 
@@ -273,6 +277,10 @@
       test('specificity of ::content > :not(template) selector', function() {
         assertComputed(document.querySelector('[is=x-specificity-nested]'), '10px');
       });
+
+      test('x-scope with no class attribute', function () {
+        assert.equal(document.querySelector('x-scope-no-class > div').className, 'style-scope x-scope-no-class');
+      })
     });
 
     test('svg classes are dynamically scoped correctly', function() {