Merge pull request #5465 from Polymer/suppress-missing-properties

Add @Suppress annotations for missing property checks.
Polymer · Jan 10, 2019 · 21930e7 · 21930e7
2 parents ccc9380 + 7f2d736
commit 21930e7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js
@@ -367,7 +367,8 @@ export const LegacyElementMixin = dedupingMixin((base) => {
      * @param {HTMLTemplateElement} template HTML template element to instance.
      * @return {!DocumentFragment} Document fragment containing the imported
      *   template content.
-    */
+     * @suppress {missingProperties} go/missingfnprops
+     */
     instanceTemplate(template) {
       let content = this.constructor._contentForTemplate(template);
       let dom = /** @type {!DocumentFragment} */

diff --git a/lib/mixins/disable-upgrade-mixin.js b/lib/mixins/disable-upgrade-mixin.js
@@ -55,7 +55,10 @@ export const DisableUpgradeMixin = dedupingMixin((base) => {
    */
   class DisableUpgradeClass extends superClass {
 
-    /** @override */
+    /**
+     * @override
+     * @suppress {missingProperties} go/missingfnprops
+     */
     static get observedAttributes() {
       return super.observedAttributes.concat(DISABLED_ATTR);
     }

diff --git a/lib/mixins/element-mixin.js b/lib/mixins/element-mixin.js
@@ -516,7 +516,7 @@ export const ElementMixin = dedupingMixin(base => {
      *
      * @return {void}
      * @override
-     * @suppress {invalidCasts}
+     * @suppress {invalidCasts,missingProperties} go/missingfnprops
      */
     _initializeProperties() {
       this.constructor.finalize();

diff --git a/lib/mixins/property-effects.js b/lib/mixins/property-effects.js
@@ -2088,6 +2088,7 @@ export const PropertyEffects = dedupingMixin(superClass => {
      * @param {string} property Property name
      * @return {void}
      * @protected
+     * @suppress {missingProperties} go/missingfnprops
      */
     _createReflectedProperty(property) {
       let attr = this.constructor.attributeNameForProperty(property);
@@ -2348,6 +2349,7 @@ export const PropertyEffects = dedupingMixin(superClass => {
      * @return {!TemplateInfo} Template metadata object; for `runtimeBinding`,
      *   this is an instance of the prototypical template info
      * @protected
+     * @suppress {missingProperties} go/missingfnprops
      */
     _bindTemplate(template, instanceBinding) {
       let templateInfo = this.constructor._parseTemplate(template);