From 0810bf3e8fa5c683f91f0154d3b25ceac8e410c2 Mon Sep 17 00:00:00 2001 From: Alexander Marks Date: Fri, 14 Jun 2019 12:32:08 -0700 Subject: [PATCH 1/2] Fix some Closure annotations --- lib/legacy/legacy-element-mixin.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js index 213c3078b4..67d31fa3fd 100644 --- a/lib/legacy/legacy-element-mixin.js +++ b/lib/legacy/legacy-element-mixin.js @@ -517,6 +517,7 @@ export const LegacyElementMixin = dedupingMixin((base) => { * is contained. This is a shorthand for * `this.getRootNode().host`. * @this {Element} + * @return {?Node} */ get domHost() { let root = wrap(this).getRootNode(); @@ -940,9 +941,9 @@ export const LegacyElementMixin = dedupingMixin((base) => { * Cross-platform helper for setting an element's CSS `translate3d` * property. * - * @param {number} x X offset. - * @param {number} y Y offset. - * @param {number} z Z offset. + * @param {number|string} x X offset. + * @param {number|string} y Y offset. + * @param {number|string} z Z offset. * @param {Element=} node Element to apply the transform to. * Defaults to `this`. * @return {void} From a6bff4360a944f5798d8b0d8c492d90545add19e Mon Sep 17 00:00:00 2001 From: Alexander Marks Date: Fri, 14 Jun 2019 12:45:57 -0700 Subject: [PATCH 2/2] Add @return description --- lib/legacy/legacy-element-mixin.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js index 67d31fa3fd..d3714a2d49 100644 --- a/lib/legacy/legacy-element-mixin.js +++ b/lib/legacy/legacy-element-mixin.js @@ -517,7 +517,8 @@ export const LegacyElementMixin = dedupingMixin((base) => { * is contained. This is a shorthand for * `this.getRootNode().host`. * @this {Element} - * @return {?Node} + * @return {?Node} The element whose local dom within which this element is + * contained. */ get domHost() { let root = wrap(this).getRootNode();