From 0c3e3c5fa962dd0bd7b3c808f939df34cd77f3f4 Mon Sep 17 00:00:00 2001 From: Steven Orvell Date: Wed, 26 Apr 2017 17:56:15 -0700 Subject: [PATCH] Fix more closure warnings. --- closure.log | 10 +--------- lib/utils/resolve-url.html | 2 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/closure.log b/closure.log index de66993c91..98a1f1e2b5 100644 --- a/closure.log +++ b/closure.log @@ -612,10 +612,6 @@ Found : PolymerElement Object.getPrototypeOf(this.prototype).constructor.importPath; ^^^^^^^^^^^^^^ -/polymer.html_script_11.js:573: WARNING - Function Polymer.ResolveUrl.resolveUrl: called with 1 argument(s). Function requires at least 2 argument(s) and at most 2. - importPath ? Polymer.ResolveUrl.resolveUrl(importPath) : ''; - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - /polymer.html_script_11.js:574: WARNING - Invalid type for parameter 1 of function finalizeTemplate. Expected : HTMLElement|null Found : Object|null @@ -665,10 +661,6 @@ Found : PolymerElement window.ShadyCSS.styleSubtree(this, properties); ^^^^ -/polymer.html_script_11.js:764: WARNING - Function Polymer.ResolveUrl.resolveUrl: called with 1 argument(s). Function requires at least 2 argument(s) and at most 2. - base = Polymer.ResolveUrl.resolveUrl(this.importPath); - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - /polymer.html_script_11.js:779: WARNING - Property _parseTemplateContent never defined on polymerElementBase of type polymerElementBase<|function(new:polymerElementBase):?|> return super._parseTemplateContent(template, templateInfo, nodeInfo); ^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -1415,4 +1407,4 @@ externs/closure-types.js:759: WARNING - property toggle on interface Polymer_Arr Polymer_ArraySelectorMixin.prototype.toggle; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -0 error(s), 309 warning(s), 72.6% typed +0 error(s), 307 warning(s), 72.6% typed diff --git a/lib/utils/resolve-url.html b/lib/utils/resolve-url.html index 7bffd134e6..4b0454eada 100644 --- a/lib/utils/resolve-url.html +++ b/lib/utils/resolve-url.html @@ -23,7 +23,7 @@ * * @memberof Polymer.ResolveUrl * @param {string} url Input URL to resolve - * @param {string} baseURI Base URI to resolve the URL against + * @param {string=} baseURI Base URI to resolve the URL against * @return {string} resolved URL */ function resolveUrl(url, baseURI) {