Add a dirty check to showHideChildren

Polymer · Jun 25, 2019 · 0ba19b4 · 0ba19b4
1 parent fc693a0
commit 0ba19b4
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/elements/dom-if.js b/lib/elements/dom-if.js
@@ -297,11 +297,12 @@ class DomIfFast extends DomIfBase {
    */
   _showHideChildren() {
     const hidden = this.__hideTemplateChildren__ || !this.if;
-    if (this.__instance) {
+    if (this.__instance && Boolean(this.__instance.__hidden) !== hidden) {
+      this.__instance.__hidden = hidden;
       showHideChildren(hidden, this.__instance.templateInfo.childNodes);
-    }
-    if (!hidden) {
-      this.__syncHostProperties();
+      if (!hidden) {
+        this.__syncHostProperties();
+      }
     }
   }
 }
@@ -397,7 +398,8 @@ class DomIfLegacy extends DomIfBase {
    */
   _showHideChildren() {
     const hidden = this.__hideTemplateChildren__ || !this.if;
-    if (this.__instance) {
+    if (this.__instance && Boolean(this.__instance.__hidden) !== hidden) {
+      this.__instance.__hidden = hidden;
       this.__instance._showHideChildren(hidden);
       if (!hidden) {
         this.__syncHostProperties();