From 00f9e3ebbec39c777f9b1da2ed285c6b920aa8e3 Mon Sep 17 00:00:00 2001 From: Daniel Freedman Date: Mon, 17 Apr 2017 14:51:04 -0700 Subject: [PATCH] [ci skip] reduce warnings --- lib/elements/array-selector.html | 4 +++- lib/legacy/legacy-element-mixin.html | 4 +++- lib/legacy/polymer-fn.html | 1 + lib/mixins/gesture-event-listeners.html | 4 +++- lib/mixins/mutable-data.html | 8 ++++++-- lib/mixins/property-effects.html | 10 ++++++---- lib/mixins/template-stamp.html | 4 +++- lib/utils/array-splice.html | 8 ++++---- lib/utils/mixin.html | 10 ++++------ lib/utils/templatize.html | 2 +- 10 files changed, 34 insertions(+), 21 deletions(-) diff --git a/lib/elements/array-selector.html b/lib/elements/array-selector.html index 88d28f1cbe..85603aaed6 100644 --- a/lib/elements/array-selector.html +++ b/lib/elements/array-selector.html @@ -39,7 +39,7 @@ * @polymerMixinClass * @implements {Polymer_ArraySelectorMixin} */ - return class extends superClass { + class ArraySelectorMixin extends superClass { static get properties() { @@ -317,6 +317,8 @@ } + return ArraySelectorMixin; + }); // export mixin diff --git a/lib/legacy/legacy-element-mixin.html b/lib/legacy/legacy-element-mixin.html index ab19527828..e831d6c1ef 100644 --- a/lib/legacy/legacy-element-mixin.html +++ b/lib/legacy/legacy-element-mixin.html @@ -63,7 +63,7 @@ * @polymerMixinClass * @implements {Polymer_LegacyElement} */ - return class LegacyElement extends legacyElementBase { + class LegacyElement extends legacyElementBase { constructor() { super(); @@ -909,6 +909,8 @@ } + return LegacyElement; + }); })(); diff --git a/lib/legacy/polymer-fn.html b/lib/legacy/polymer-fn.html index 29258b55a9..1a145c94bc 100644 --- a/lib/legacy/polymer-fn.html +++ b/lib/legacy/polymer-fn.html @@ -24,6 +24,7 @@ * * See `Polymer.Class` for details on valid legacy metadata format for `info`. * + * @override * @function Polymer * @param {Object} info Object containing Polymer metadata and functions * to become class methods. diff --git a/lib/mixins/gesture-event-listeners.html b/lib/mixins/gesture-event-listeners.html index abd8eae711..dcf163daef 100644 --- a/lib/mixins/gesture-event-listeners.html +++ b/lib/mixins/gesture-event-listeners.html @@ -37,7 +37,7 @@ * @polymerMixinClass * @implements {Polymer_GestureEventListeners} */ - return class GestureEventListeners extends superClass { + class GestureEventListeners extends superClass { _addEventListenerToNode(node, eventName, handler) { if (!gestures.addListener(node, eventName, handler)) { @@ -53,6 +53,8 @@ } + return GestureEventListeners; + }); })(); diff --git a/lib/mixins/mutable-data.html b/lib/mixins/mutable-data.html index 8e090fed3c..9cb64930fe 100644 --- a/lib/mixins/mutable-data.html +++ b/lib/mixins/mutable-data.html @@ -76,7 +76,7 @@ * @polymerMixinClass * @implements {Polymer_MutableData} */ - return class MutableData extends superClass { + class MutableData extends superClass { /** * Overrides `Polymer.PropertyEffects` to provide option for skipping * strict equality checking for Objects and Arrays. @@ -100,6 +100,8 @@ } + return MutableData; + }); /** @@ -145,7 +147,7 @@ * @polymerMixinClass * @implements {Polymer_OptionalMutableData} */ - return class OptionalMutableData extends superClass { + class OptionalMutableData extends superClass { static get properties() { return { @@ -181,6 +183,8 @@ } } + return OptionalMutableData; + }); // Export for use by legacy behavior diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html index 74a740cb5c..aefcd5f3fd 100644 --- a/lib/mixins/property-effects.html +++ b/lib/mixins/property-effects.html @@ -24,6 +24,7 @@ 'use strict'; + /** @const {Object} */ const CaseMap = Polymer.CaseMap; // Monotonically increasing unique ID used for de-duping effects triggered @@ -86,7 +87,7 @@ * on an instance. * * @param {Object} inst The instance with effects to run - * @param {string} effects Array of effects to run for this property + * @param {Object} effects Array of effects to run for this property * @param {Object} props Bag of current property changes * @param {Object=} oldProps Bag of previous values for changed properties * @param {boolean=} hasPaths True with `props` contains one or more paths @@ -96,7 +97,7 @@ */ function runEffects(inst, effects, props, oldProps, hasPaths, extraArgs) { if (effects) { - let ran; + let ran = false; let id = dedupeId++; for (let prop in props) { if (runEffectsForProperty(inst, effects, id, prop, props, oldProps, hasPaths, extraArgs)) { @@ -105,13 +106,14 @@ } return ran; } + return false; } /** * Runs a list of effects for a given property. * * @param {Object} inst The instance with effects to run - * @param {Array} effects Array of effects + * @param {Object} effects Array of effects * @param {number} dedupeId Counter used for de-duping effects * @param {string} prop Name of changed property * @param {*} props Changed properties @@ -122,7 +124,7 @@ * @private */ function runEffectsForProperty(inst, effects, dedupeId, prop, props, oldProps, hasPaths, extraArgs) { - let ran; + let ran = false; let rootProperty = hasPaths ? Polymer.Path.root(prop) : prop; let fxs = effects[rootProperty]; if (fxs) { diff --git a/lib/mixins/template-stamp.html b/lib/mixins/template-stamp.html index ddd58452e3..af17ee3bfe 100644 --- a/lib/mixins/template-stamp.html +++ b/lib/mixins/template-stamp.html @@ -116,7 +116,7 @@ * @polymerMixinClass * @implements {Polymer_TemplateStamp} */ - return class TemplateStamp extends superClass { + class TemplateStamp extends superClass { _initializeProperties() { super._initializeProperties(); @@ -469,6 +469,8 @@ } + return TemplateStamp; + }); })(); diff --git a/lib/utils/array-splice.html b/lib/utils/array-splice.html index 34bd0b7b0b..9008ebffe8 100644 --- a/lib/utils/array-splice.html +++ b/lib/utils/array-splice.html @@ -150,15 +150,15 @@ * * @param {Array} current The current "changed" array for which to * calculate splices. - * @param {Integer} currentStart Starting index in the `current` array for + * @param {number} currentStart Starting index in the `current` array for * which splices are calculated. - * @param {Integer} currentEnd Ending index in the `current` array for + * @param {number} currentEnd Ending index in the `current` array for * which splices are calculated. * @param {Array} old The original "unchanged" array to compare `current` * against to determine splices. - * @param {Integer} oldStart Starting index in the `old` array for + * @param {number} oldStart Starting index in the `old` array for * which splices are calculated. - * @param {Integer} oldEnd Ending index in the `old` array for + * @param {number} oldEnd Ending index in the `old` array for * which splices are calculated. * @return {Array} Returns an array of splice record objects. Each of these * contains: `index` the location where the splice occurred; `removed` diff --git a/lib/utils/mixin.html b/lib/utils/mixin.html index 661de88889..12a4ebb3c8 100644 --- a/lib/utils/mixin.html +++ b/lib/utils/mixin.html @@ -22,9 +22,8 @@ /** * Given a mixin producing function, memoize applications of mixin to base * @private - * @template T - * @param {T} mixin Mixin for which to create a caching mixin. - * @return {T} Returns a mixin which when applied multiple times to the + * @param {Function} mixin Mixin for which to create a caching mixin. + * @return {Function} Returns a mixin which when applied multiple times to the * same base will always return the same extended class. */ function cachingMixin(mixin) { @@ -48,9 +47,8 @@ * applications. * * @memberof Polymer - * @template {T} - * @param {T} mixin ES6 class expression mixin to wrap - * @return {T} Wrapped mixin that deduplicates and memoizes + * @param {Function} mixin ES6 class expression mixin to wrap + * @return {Function} Wrapped mixin that deduplicates and memoizes * mixin applications to base */ Polymer.dedupingMixin = function(mixin) { diff --git a/lib/utils/templatize.html b/lib/utils/templatize.html index 25786cfc6e..456c01510f 100644 --- a/lib/utils/templatize.html +++ b/lib/utils/templatize.html @@ -42,7 +42,7 @@ // Base class for TemplateInstance's /** * @constructor - * @mixes {Polymer_PropertyEffects} + * @implements {Polymer_PropertyEffects} */ const base = Polymer.PropertyEffects(class {}); class TemplateInstanceBase extends base {