This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
reviewed
May 5, 2018
README.md
Outdated
@@ -107,9 +107,9 @@ This will create a `modulizer_workspace` directory and checkout the repos and th | |||
|
|||
Setting the import style allows you to set whether JavaScript imports are specified by npm package name, or relative file path. Importing specifiers that use package names are easier for third-party packages to work with, but unlike paths they currently can not run natively on the web. Defaults to "path". | |||
|
|||
#### `--add-import-path` | |||
#### `--remove-import-meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would lean towards keeping --add-import-path
and just changing the default to true
.
implemented changes! |
aomarks
reviewed
May 5, 2018
README.md
Outdated
|
||
If included, the static `importPath` property will be added to converted Polymer elements. See [the `importPath` documentation](https://www.polymer-project.org/2.0/docs/devguide/dom-template) for more information. | ||
True by default, but if set to false, the static `importMeta` property will not be added to converted Polymer elements. See [the `importPath` documentation](https://www.polymer-project.org/2.0/docs/devguide/dom-template) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just say "True by default. Add a static importMeta
property to converted Polymer elements." or something (less negatives)
aomarks
approved these changes
May 5, 2018
aomarks
approved these changes
May 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
--add-import-path
and changed it to--remove-import-meta
. It might be useful to look at the individual commits to filter out all the testsbefore:
The flag,
--add-import-meta
, that defaulted tofalse
, would addThis was no longer supported in Polymer/polymer#5180
after:
The flag is now
--remove-import-meta
(false
by default). So, by default we insert:By adding the
--remove-import-meta
flag, the user can opt out of this insertion (which is now on by default).