Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid native attribute names #2747

Open
yo3jones opened this issue Jan 23, 2018 · 6 comments
Open

Invalid native attribute names #2747

yo3jones opened this issue Jan 23, 2018 · 6 comments

Comments

@yo3jones
Copy link

Getting this browser error at runtime:

Uncaught DOMException: Failed to execute 'setAttribute' on 'Element': 'aria-live\' is not a valid attribute name.

It looks like the escape of the $ is not necessary, which leads to a trailing back slash.

Example can be seen in iron-a11y-announcer

<div aria-live\$="[[mode]]">[[_text]]</div>

will work if the \ is removed:

<div aria-live$="[[mode]]">[[_text]]</div>
@venicia
Copy link

venicia commented Jan 24, 2018

Is this actively being worked on?

@stramel
Copy link
Contributor

stramel commented Jan 24, 2018

Probably not yet as it was opened 20 hrs ago. I'm sure it will be in the near future unless you want to put out a PR to fix it 🙂

@usergenic
Copy link
Contributor

Added Polymer/polymer#5060

@usergenic
Copy link
Contributor

I can see this using .raw in Polymer's html-tag may be an issue in every other place involving a $ or escaped backtick characters etc.

@usergenic
Copy link
Contributor

Update: This is actively being worked on in the context of Polymer/polymer 2.next and upcoming 3.0 prerelease version as we speak. Modulizer output is still going to emit the escaping for forseeable future for all dollar signs, backticks and backslashes.

@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants