Remove ALL_CAPS variables for closure compatibility

Fixes #82 Style: Mutated Closure Constant Variables
googlearchive · Dec 12, 2014 · de5aa39 · de5aa39
1 parent 17a6304
commit de5aa39
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/mouse.js b/src/mouse.js
@@ -15,7 +15,7 @@
 
   var WHICH_TO_BUTTONS = [0, 1, 4, 2];
 
-  var CURRENT_BUTTONS = 0;
+  var currentButtons = 0;
 
   var FIREFOX_LINUX = /Linux.*Firefox\//i;
 
@@ -79,11 +79,11 @@
         var type = inEvent.type;
         var bit = WHICH_TO_BUTTONS[inEvent.which] || 0;
         if (type === 'mousedown') {
-          CURRENT_BUTTONS |= bit;
+          currentButtons |= bit;
         } else if (type === 'mouseup') {
-          CURRENT_BUTTONS &= ~bit;
+          currentButtons &= ~bit;
         }
-        e.buttons = CURRENT_BUTTONS;
+        e.buttons = currentButtons;
       }
       return e;
     },
@@ -105,7 +105,7 @@
           // handle case where we missed a mouseup
           if ((HAS_BUTTONS ? e.buttons : e.which) === 0) {
             if (!HAS_BUTTONS) {
-              CURRENT_BUTTONS = e.buttons = 0;
+              currentButtons = e.buttons = 0;
             }
             dispatcher.cancel(e);
             this.cleanupMouse(e.buttons);

diff --git a/src/targetfind.js b/src/targetfind.js
@@ -8,7 +8,7 @@
  */
 
 (function(scope) {
-  var HAS_FULL_PATH = false;
+  var hasFullPath = false;
 
   // test for full event path support
   var pathTest = document.createElement('meta');
@@ -19,7 +19,7 @@
     pathTest.addEventListener('testpath', function(ev) {
       if (ev.path) {
         // if the span is in the event path, then path[0] is the real source for all events
-        HAS_FULL_PATH = ev.path[0] === s;
+        hasFullPath = ev.path[0] === s;
       }
       ev.stopPropagation();
     });
@@ -96,7 +96,7 @@
       return s;
     },
     findTarget: function(inEvent) {
-      if (HAS_FULL_PATH && inEvent.path && inEvent.path.length) {
+      if (hasFullPath && inEvent.path && inEvent.path.length) {
         return inEvent.path[0];
       }
       var x = inEvent.clientX, y = inEvent.clientY;
@@ -110,7 +110,7 @@
     },
     findTouchAction: function(inEvent) {
       var n;
-      if (HAS_FULL_PATH && inEvent.path && inEvent.path.length) {
+      if (hasFullPath && inEvent.path && inEvent.path.length) {
         var path = inEvent.path;
         for (var i = 0; i < path.length; i++) {
           n = path[i];
@@ -189,7 +189,7 @@
     },
     path: function(event) {
       var p;
-      if (HAS_FULL_PATH && event.path && event.path.length) {
+      if (hasFullPath && event.path && event.path.length) {
         p = event.path;
       } else {
         p = [];