polymer-expressions: oneTime

[email protected], arv BUG= Review URL: https://codereview.appspot.com/43690044
googlearchive · Dec 18, 2013 · d7c089e · d7c089e
1 parent 5edddb4
commit d7c089e
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 3 deletions.
diff --git a/src/polymer-expressions.js b/src/polymer-expressions.js
@@ -49,8 +49,8 @@
       return;
     }
 
-    return function(model, node) {
-      var binding = expression.getBinding(model, filterRegistry);
+    return function(model, node, oneTime) {
+      var binding = expression.getBinding(model, filterRegistry, oneTime);
       if (expression.scopeIdent && binding) {
         node.polymerExpressionScopeIdent_ = expression.scopeIdent;
         if (expression.indexIdent)
@@ -368,8 +368,22 @@
   }
 
   Expression.prototype = {
-    getBinding: function(model, filterRegistry) {
+    getBinding: function(model, filterRegistry, oneTime) {
       var paths = this.paths;
+      if (oneTime) {
+        var values;
+
+        if (paths.length == 1) {
+          values = paths[0].getValueFrom(model);
+        } else if (paths.length > 1) {
+          values = [];
+          for (var i = 0; i < paths.length; i++)
+            values[i] = paths[i].getValueFrom(model);
+        }
+
+        return this.getValue(values, filterRegistry, model);
+      }
+
       if (!paths.length) {
         // only literals in expression.
         return new ConstantObservable(this.getValue(undefined, filterRegistry,

diff --git a/tests/tests.js b/tests/tests.js
@@ -129,6 +129,23 @@ suite('PolymerExpressions', function() {
     assertLacksClass(target, 'foo');
   });
 
+
+  test('ClassName Singular Static', function() {
+    var div = createTestHtml(
+        '<template bind><div class="[[ {foo: bar} | tokenList ]]">' +
+        '</div></template>');
+    var model = {bar: 1};
+    recursivelySetTemplateModel(div, model);
+    Platform.performMicrotaskCheckpoint();
+
+    var target = div.childNodes[1];
+    assertHasClass(target, 'foo');
+
+    model.bar = 0;
+    Platform.performMicrotaskCheckpoint();
+    assertHasClass(target, 'foo');
+  });
+
   test('ClassName Multiple', function() {
     var div = createTestHtml(
         '<template bind>' +
@@ -154,6 +171,31 @@ suite('PolymerExpressions', function() {
     assertHasClass(target, 'boo');
   });
 
+  test('ClassName Multiple - static', function() {
+    var div = createTestHtml(
+        '<template bind>' +
+        '<div class="[[ {foo: bar, baz: bat > 1, boo: bot.bam} ' +
+            '| tokenList ]]">' +
+        '</div></template>');
+    var model = {bar: 1, bat: 1, bot: { bam: 1 }};
+    recursivelySetTemplateModel(div, model);
+    Platform.performMicrotaskCheckpoint();
+
+    var target = div.childNodes[1];
+    assert.strictEqual('foo boo', target.className);
+    assertHasClass(target, 'foo');
+    assertLacksClass(target, 'baz');
+    assertHasClass(target, 'boo');
+
+    model.bar = 0;
+    model.bat = 2;
+    Platform.performMicrotaskCheckpoint();
+    assert.strictEqual('foo boo', target.className);
+    assertHasClass(target, 'foo');
+    assertLacksClass(target, 'baz');
+    assertHasClass(target, 'boo');
+  });
+
   test('tokenList', function() {
     var div = createTestHtml(
         '<template bind>' +
@@ -175,6 +217,27 @@ suite('PolymerExpressions', function() {
     assert.strictEqual('bar bot', target.className);
   });
 
+  test('tokenList - static', function() {
+    var div = createTestHtml(
+        '<template bind>' +
+        '<div class="[[ object | tokenList ]]">' +
+        '</div></template>');
+
+    var model = {
+      object: {bar: 1, bat: 1, bot: {bam: 1}}
+    };
+    recursivelySetTemplateModel(div, model);
+    Platform.performMicrotaskCheckpoint();
+
+    var target = div.childNodes[1];
+    assert.strictEqual('bar bat bot', target.className);
+
+    model.object = {bar: 1, bot: 1};
+    Platform.performMicrotaskCheckpoint();
+
+    assert.strictEqual('bar bat bot', target.className);
+  });
+
   test('styleObject', function() {
     // IE removes invalid style attribute values so we use xstyle in this test.