add deserialization support for undefined valued properties.

googlearchive · Jul 24, 2014 · cb37bad · cb37bad
1 parent 1a67a4c
commit cb37bad
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/src/lib/deserialize.js b/src/lib/deserialize.js
@@ -9,10 +9,13 @@
 
 (function(scope) {
 
+  function noopHandler(value) {
+    return value;
+  }
+
   var typeHandlers = {
-    string: function(value) {
-      return value;
-    },
+    string: noopHandler,
+    'undefined': noopHandler,
     date: function(value) {
       return new Date(Date.parse(value) || Date.now());
     },

diff --git a/test/html/prop-attr-reflection.html b/test/html/prop-attr-reflection.html
@@ -17,6 +17,21 @@
   </head>
   <body>
 
+    <x-basic></x-basic>
+    <polymer-element name="x-basic" attributes="nog" noscript>
+    </polymer-element>
+
+    <x-attr-publish></x-attr-publish>
+    <polymer-element name="x-attr-publish" attributes="nog">
+      <script>
+        Polymer('x-attr-publish', {
+          publish: {
+            nog: {value: '', reflect: false}
+          }
+        });
+      </script>
+    </polymer-element>
+
     <x-foo></x-foo>
     <polymer-element name="x-foo">
       <script>
@@ -80,8 +95,19 @@
       }
 
       document.addEventListener('polymer-ready', function() {
+        var xbasic = document.querySelector('x-basic');
+        assert.equal(xbasic.nog, undefined, 'property published with `attributes` has correct initial value');
+        xbasic.setAttribute('nog', 'hi');
+        assert.equal(xbasic.nog, 'hi', 'deserialization of property published via `attributes`');
+
+        var xattrpublish = document.querySelector('x-attr-publish');
+        assert.equal(xattrpublish.nog, '', 'property published with `attributes` has correct initial value');
+        xattrpublish.setAttribute('nog', 'hi');
+        assert.equal(xattrpublish.nog, 'hi', 'deserialization of property published via `attributes`');
+
         var xcompose = document.querySelector('x-compose');
         var xfoo = document.querySelector('x-foo');
+        assert.equal(xfoo.foo, '', 'property published with info object has correct initial value');
         xfoo.foo = 5;
         xfoo.setAttribute('def1', '15');
         xfoo.def2 = 15;
@@ -98,6 +124,8 @@
         assert.equal(xfoo.baz, xfoo.getAttribute('baz'), 'attribute reflects property');
         //
         var xbar = document.querySelector('x-bar');
+        assert.equal(xbar.zim, false, 'property published with info object has correct initial value');
+        assert.equal(xbar.foo, '', 'property published with info object has correct initial value');
         //
         xbar.foo = 'foo!';
         xbar.zot = 27;