Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Commit

Permalink
Turn on property observation earlier. This change enhances compatibil…
Browse files Browse the repository at this point in the history
…ity with previous behavior for the time being. It will probably be changed back soon.
  • Loading branch information
sorvell committed Apr 17, 2014
1 parent bad4a4e commit 1ca8375
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/instance/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
this.shadowRoots = {};
// install property observers
this.createPropertyObserver();
// TODO (sorvell): temporarily open observer when created
this.openPropertyObserver();
// install boilerplate attributes
this.copyInstanceAttributes();
// process input attributes
Expand All @@ -54,6 +56,10 @@
this.addHostListeners();
},
makeElementReady: function() {
if (this._readied) {
return;
}
this._readied = true;
// TODO(sorvell): We could create an entry point here
// for the user to compute property values.
// process declarative resources
Expand All @@ -64,8 +70,9 @@
this.removeAttribute('unresolved');
// user entry point
this.ready();
// TODO (sorvell): temporarily open observer when created
// turn on property observation and take any initial changes
this.openPropertyObserver();
//this.openPropertyObserver();
},
attachedCallback: function() {
this.cancelUnbindAll();
Expand Down

0 comments on commit 1ca8375

Please sign in to comment.