This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add build support for :dir() in Polymer 2+
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dfreedm
commented
Nov 6, 2018
dfreedm
commented
- CHANGELOG.md has been updated
dfreedm
requested review from
rictic,
sorvell and
kevinpschaaf
and removed request for
sorvell
rictic
approved these changes
Nov 7, 2018
| */ | ||
|
|
||
| // copied from polymer DirMixin | ||
| const HOST_DIR = /:host\(:dir\((ltr|rtl)\)\)/g; |
There was a problem hiding this comment.
Interesting, so you're transforming a native :dir pseudo-selector into an attribute selector?
There was a problem hiding this comment.
Yes, and then Polymer's runtime handles setting the dir attribute on any instance that needed it.
sorvell
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.