Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Fix shady-unscoped styles and add tests #24

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Nov 5, 2018

  • CHANGELOG.md has been updated

Styles with shady-unscoped attribute should be collected as "leftover" style imports to be done at runtime.

@dfreedm dfreedm requested a review from rictic November 5, 2018 19:24
@rictic
Copy link
Contributor

rictic commented Nov 5, 2018

Was this already downstreamed internally, or is this another, similar change?

Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is upstreaming cl/217800007, LGTM

@dfreedm dfreedm merged commit 249b5ad into master Nov 5, 2018
@dfreedm dfreedm deleted the shady-unscoped-fix branch November 5, 2018 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants