This repository has been archived by the owner on Sep 14, 2021. It is now read-only.
stop directly modifying the object passed to generateServiceWorker() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let project = options.project; | ||
| let buildRoot = options.buildRoot; | ||
| let swConfig: SWConfig = options.swConfig || {}; | ||
| let swConfig: SWConfig = Object.assign({}, options.swConfig); | ||
|
|
||
| return project.analyzer.analyzeDependencies.then((depsIndex: DepsIndex) => { | ||
| let staticFileGlobs = swConfig.staticFileGlobs || []; |
There was a problem hiding this comment.
to make sure, you might want to do similar here:
let staticFileGlobs = Array.from(swConfig.staticFileGlobs || []);
There was a problem hiding this comment.
we actually never modify swConfig.staticFileGlobs. Instead we return new arrays via concat and then overwrite the staticFileGlobs property with one of those new arrays. So this isn't an issue today.
BUT you're right, code changes and this might not be the case forever. I'll add this extra precaution back in.
|
LGTM |
FredKSchott
force-pushed
the
fix-service-worker-options-bug
branch
from
b0b8eee
to
914c453
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Polymer/polymer-cli/issues/345
This is much more serious than I thought, service-worker generation is currently broken in the CLI when a user defines their own
swConfig.staticFileGlobsarray./cc @justinfagnani Lets get this merged in ASAP along with the
polymer.jsonCLI fix