This repository has been archived by the owner on May 1, 2019. It is now read-only.
Update Javascript parser to recast + esprima #722
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with
document.stringify()
, I discovered that comments in JS ASTs are duplicated. This seemed to be an artifact ofespree
. By switching torecast
, this issue is fixed.This also opens the door for parsing Typescript, when benjamn/recast#424 is resolved.There are still some outstanding issues regarding unreported malformedness, but also it seems to fail on parsing
console.log()
with the following error:I have no clue what is going on there. Modifying the test does not seem to report any other error and sadly this issue manifests in my usage of the analyzer as well.
Any pointers for fixing the last few test errors would be greatly appreciated, as I seem to be stuck on fixing them 😢