analyzer class issues

[aomarks]

Found some issues with the analyzer output for classes in the Polymer 2.0 core library:

$ git clone [email protected]:Polymer/polymer
$ cd polymer
$ polymer analyze > analysis.json

1. The Debouncer class (https://github.com/Polymer/polymer/blob/master/lib/utils/debounce.html) is in top level classes, but I expected it to be in namespaces.Polymer.classes. Interesting that it has a @memberof Polymer annotation. The only class that does make it into the Polymer namespace is FlattenedNodesObserver (https://github.com/Polymer/polymer/blob/master/lib/utils/flattened-nodes-observer.html) and it does not have that annotation.

2. The description for Debouncer is eslint-disable-line no-unused-vars, which is a standalone comment on the line before the class declaration. The class declaration has no jsdoc block.

3. There's a top-level public class with no name from https://github.com/Polymer/polymer/blob/master/lib/utils/templatize.html. Line 46 is actually just a comment, so I wonder if there's also an issue with source offset?

    {
      "description": "",
      "summary": "",
      "path": "lib/utils/templatize.html",
      "properties": [],
      "methods": [],
      "demos": [],
      "metadata": {},
      "sourceRange": {
        "start": {
          "line": 46,
          "column": 41
        },
        "end": {
          "line": 46,
          "column": 49
        }
      },
      "privacy": "public"
    },

4. There are 2x top-level public klass classes generated again from https://github.com/Polymer/polymer/blob/master/lib/utils/templatize.html.

[rictic]

Hm, 1, 3, and 4 seem like bugs. #2 strikes me as working as intended, and the solution is to write a line or two of documentation for the Debouncer class.

[aomarks]

On #2, the comment seems fairly clearly not attached to the class declaration because it's an end of line comment for another symbol's declaration, and also there's a line break inbetween:

  let AsyncModule; // eslint-disable-line no-unused-vars

  class Debouncer {

https://github.com/Polymer/polymer/blob/master/lib/utils/debounce.html

[web-padawan]

I confirm that placing the block ending with comment causes error in #674:

/* eslint-disable camelcase */
var DESTINATION_MAP = {
    google_analytics: 'selectAnalyticsAccess',
    click_house: 'selectClickHouseAccess'
};
/* eslint-enable camelcase */

Polymer({
    is: 'my-element',

So, analyzer treats eslint comments as meaningful, which produces a LOT of output (all of the element code gets printed to console and underlined, oops).

This bug does not exist as of [email protected].

[homerjonathan]

I have also had commenting errors.

ScannedPolymerElement has both HTML doc and JSDoc comments.

I managed to remove the errors I have this at the top

<!--
   Top Documentation
->

Then in the <script> section I have

// Script Notes

This returns the above error. Remove the line with two forward slashes comments, and it no longer shows the errors.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.