Do not rewrite '/' absolute urls

Make URL test actually test the url resolver Fixes Polymer/platform#63
googlearchive · Apr 19, 2014 · 55131c2 · 55131c2
1 parent c90023a
commit 55131c2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/src/url.js b/src/url.js
@@ -85,6 +85,10 @@ function replaceUrlsInCssText(cssText, baseUrl, regexp) {
 }
 
 function resolveRelativeUrl(baseUrl, url) {
+  // do not resolve '/' absolute urls
+  if (url && url[0] === '/') {
+    return url;
+  }
   var u = new URL(url, baseUrl);
   return makeDocumentRelPath(u.href);
 }

diff --git a/test/html/url.html b/test/html/url.html
@@ -13,14 +13,20 @@
   <script src="../../platform.js"></script>
 </head>
 <body>
+  <template>
+    <b id="a" href="/1/2"></b>
+    <b id="b" href="2/../3/4"></b>
+    <b id="c" href="{{ path }}/baz"></b>
+  </template>
   <script>
-    var root = document.location;
-    var path = '/foo/bar';
-    var u = new URL(path, root);
-    chai.assert.equal(u.host, root.host);
-    chai.assert.equal(u.port, root.port);
-    chai.assert.equal(u.protocol, root.protocol);
-    chai.assert.equal(u.pathname, path);
+    function getUrl(template, id, attr) {
+      return template.content.querySelector('#' + id).getAttribute(attr);
+    }
+    var t = document.querySelector('template');
+    Platform.urlResolver.resolveTemplate(t);
+    chai.assert.equal(getUrl(t, 'a', 'href'), '/1/2');
+    chai.assert.equal(getUrl(t, 'b', 'href'), '3/4');
+    chai.assert.equal(getUrl(t, 'c', 'href'), '{{ path }}/baz');
     done();
   </script>
 </body>