Adds minor new API for enabling updating and querying assigned nodes. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2019 14:02
By default this is called in `connectedCallback`. Subclasses can customize when updating is initialized by overriding `connectedCallback` and calling `initializeUpdating`.
|
Will this return the same nodes/be updated in the same way regardless of whether using the polyfill or not? |
rictic
approved these changes
Dec 5, 2019
src/lib/decorators.ts
Outdated
| * A property decorator that converts a class property into a getter that | ||
| * returns the `assignedNodes` of the given named `slot`. | ||
| * | ||
| * @ExportDecoratedItems |
There was a problem hiding this comment.
This doesn't need to be @ExportDecoratedItems any more, as of angular/tsickle#1125
justinfagnani
requested changes
Dec 5, 2019
CHANGELOG.md
Outdated
| @@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| <!-- ### Added --> | |||
| <!-- ### Removed --> | |||
|
|
|||
| ### Added | |||
| * Added `enableUpdating()` to `UpdatingElement` to enable customizing when updating is enabled. | |||
There was a problem hiding this comment.
SInce it doesn't look like we have issues for these, can you link to this PR?
src/lib/decorators.ts
Outdated
|
|
||
| /** | ||
| * A property decorator that converts a class property into a getter that | ||
| * returns the `assignedNodes` of the given named `slot`. |
There was a problem hiding this comment.
I think we should document the type that the property should be annotated with, ie NodeListOf<HTMLElement>
justinfagnani
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a protected method called
enableUpdatingtoUpdatingElement. Before this, updating is enabled when the element is connected in a way that is not easily customizable. Adding this API enables subclasses to control when updates are allowed to begin.Adds a
queryAssignedNodes(slotName: string, flatten: boolean)decorator. This provides a convenient way to retrieve the nodes distributed to a given slot via a property and is a shorthand forthis.shadowRoot.querySelectorAll(slot[name=${slotName}]).assignedNodes(flatten).