Add disconnectedCallback stub. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon reflection and review of https://github.com/Polymer/polymer/blob/master/lib/mixins/properties-mixin.js, I wonder if this would be better applied in https://github.com/Polymer/lit-element/blob/master/src/lit-element.ts with the same extension protection syntax as properites-mixin.js did? |
|
@Westbrook this is a very nice catch. I was wondering about this the other day. |
6 tasks
sorvell
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Disconnected stub allows for feature additions in the disconnect phase of the element lifecycle as needed without it being a breaking change, while making it possible to apply
super.disconnectedCallback()in all extensions.