-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0.0 #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's enable linting and formatting from the get go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I'm very excited for this middleware. I think bare module specifiers are the number 1 initial stumbling block for our users, so having this as such an easy drop-in solution is going to help a lot.
Some first pass comments, I'll do another pass at the code more closely after.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
… take a single optional string parameter for the packageRoot, defaulting to '.'
Trying this out with some real-world modules, and we're definitely going to need the logic from our existing resolver that uses the package.json module field when present: https://github.com/Polymer/tools/blob/master/packages/analyzer/src/javascript/resolve-specifier-node.ts#L62 |
…and main support as well as .json and .node extension support for resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 pending minor comments from me (in the package.json and the tsconfig), but otherwise LGTM!
…ngSomething to somethingSomething.
FYI: I now log errors in the middleware and then leave the response body alone; errors either from parsing or specifier resolution won't blow up the request handler anymore. |
No description provided.