guarantee overflow is not position static.

googlearchive · Sep 16, 2014 · 6168224 · 6168224
1 parent 4587cae
commit 6168224
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/core-overlay.html b/core-overlay.html
@@ -329,19 +329,13 @@ <h2>Dialog</h2>
       if (transition) {
         transition.setup(this.target);
       }
-      var computed = getComputedStyle(this.target);
       var style = this.target.style;
-      var isStatic = computed.position === 'static';
-      var defaultPosition = 'fixed';
-      // TODO(sorvell): bc 
-      this.targetStyle = {
-        position: isStatic ? defaultPosition : computed.position
-      };
-      if (isStatic) {
+      var computed = getComputedStyle(this.target);
+      if (computed.position === 'static') {
         style.position = 'fixed';
       }
-      this.target.style.outline = 'none';
-      this.target.style.display = 'none';
+      style.outline = 'none';
+      style.display = 'none';
     },
 
     openedChanged: function() {
@@ -380,6 +374,7 @@ <h2>Dialog</h2>
         // if we are showing, then take care when measuring
         this.prepareMeasure();
         this.measure();
+        this.positionTarget();
         this.updateTargetDimensions();
         this.finishMeasure();
         if (this.layered) {