ensure overlay is not statically positioned.

googlearchive · Sep 12, 2014 · 051babf · 051babf
1 parent 21e07fc
commit 051babf
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/core-overlay.html b/core-overlay.html
@@ -325,17 +325,18 @@ <h2>Dialog</h2>
       if (transition) {
         transition.setup(this.target);
       }
-      // TODO(sorvell): bc 
       var computed = getComputedStyle(this.target);
+      var style = this.target.style;
+      var isStatic = computed.position === 'static';
+      var defaultPosition = 'fixed';
+      // TODO(sorvell): bc 
       this.targetStyle = {
-        position: computed.position === 'static' ? 'fixed' :
-            computed.position
+        position: isStatic ? defaultPosition : computed.position
       };
-      if (!transition) {
-        this.target.style.outline = 'none';
-        // TODO(sorvell): needed for bc for now.
-        this.target.style.position = this.targetStyle.position;
+      if (isStatic) {
+        style.position = 'fixed';
       }
+      this.target.style.outline = 'none';
       this.target.style.display = 'none';
     },