Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Commit

Permalink
bower.json needs polymer b/c core-action-icons doesnt depend on it
Browse files Browse the repository at this point in the history
  • Loading branch information
@ebidel
ebidel committed May 15, 2014
1 parent 0daa97f commit 41e59bf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"private": true,
"dependencies": {
"platform": "Polymer/platform#master",
"polymer": "Polymer/polymer#master",
"core-action-icons": "Polymer/core-action-icons#master"
}
}
}

5 comments on commit 41e59bf

@akhileshgupta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to be causing the bower install to hang. My guess is that this is due a circular dependency on polymer. Have a simple bower.json with following content:

{
"name": "test-elements",
"version": "0.0.0",
"dependencies": {
"polymer": "Polymer/polymer#0.3.1"
}
}

Running "bower install" first time works fine, but re-running it seems to hang. Once I remove this line from the ".bower.json" in the downloaded package, "bower install" works fine thereafter.

@robdodson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey akhilesh,

There's a bower bug for this issue over her: bower/bower#1169
They claim that it's been fixed on master. Hopefully a new release is coming soon :)

@akhileshgupta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Yeah I was hoping that bower should fix it soon. Seems like they posted a new version couple hours ago and it seems to work now.

BTW, do we still need this dependency on polymer here, since core-action-icons has been EOL'd?

@akhileshgupta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just looked at the core-component-page code. It also depends on polymer. Makes sense then. Thanks Rob for pointing to the bower bug!!

@ebidel
Copy link
Contributor Author

@ebidel ebidel commented on 41e59bf Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bower 1.3.4 was just pushed and fixes this issue.

Please sign in to comment.