Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Commit

Permalink
fix(core-xhr.html): GET params sometimes not be added to querystring
Browse files Browse the repository at this point in the history
If the method is set to "get" (instead of "GET") via the options, params will not be URL encoded and included as query parameters in the URI.  Case should not be a factor when checking the method of the request.
  • Loading branch information
rnicholus committed Aug 8, 2014
1 parent 7c827ff commit 132c4b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core-xhr.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
var async = !options.sync;
//
var params = this.toQueryString(options.params);
if (params && method == 'GET') {
if (params && method.toUpperCase() == 'GET') {
url += (url.indexOf('?') > 0 ? '&' : '?') + params;
}
var xhrParams = this.isBodyMethod(method) ? (options.body || params) : null;
Expand Down

0 comments on commit 132c4b3

Please sign in to comment.