Fix template.ref

R=arv, jmesserly BUG= Review URL: https://codereview.appspot.com/52350043
googlearchive · Jan 14, 2014 · 5c5109f · 5c5109f
1 parent b0d1fc9
commit 5c5109f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/TemplateBinding.js b/src/TemplateBinding.js
@@ -496,7 +496,8 @@
           ref = treeScope.getElementById(refId);
         if (!ref) {
           var instanceRoot = getInstanceRoot(this);
-          ref = instanceRoot.querySelector('#' + refId);
+          if (instanceRoot)
+            ref = instanceRoot.querySelector('#' + refId);
         }
       }
 

diff --git a/tests/tests.js b/tests/tests.js
@@ -3006,6 +3006,17 @@ suite('Binding Delegate API', function() {
       done();
     });
   });
+
+  test('issue-152', function() {
+    var div = createTestHtml(
+        '<template ref=notThere></template>');
+
+    var template = div.firstChild;
+
+    // if a ref cannot be located, a template will continue to use itself
+    // as the source of template instances.
+    assert.strictEqual(template, template.ref);
+  });
 });
 
 suite('Compat', function() {