Micro optimize Node contains

googlearchive · Feb 27, 2014 · b9217f8 · b9217f8
1 parent 7578669
commit b9217f8
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/wrappers/Node.js b/src/wrappers/Node.js
@@ -264,6 +264,15 @@
     return clone;
   }
 
+  function contains(self, child) {
+    // TODO(arv): Optimize using ownerDocument etc.
+    for (var node = child; node; node = node.parentNode) {
+      if (node === self)
+        return true;
+    }
+    return false;
+  }
+
   var OriginalNode = window.Node;
 
   /**
@@ -640,18 +649,7 @@
     },
 
     contains: function(child) {
-      if (!child)
-        return false;
-
-      child = wrapIfNeeded(child);
-
-      // TODO(arv): Optimize using ownerDocument etc.
-      if (child === this)
-        return true;
-      var parentNode = child.parentNode;
-      if (!parentNode)
-        return false;
-      return this.contains(parentNode);
+      return contains(this, wrapIfNeeded(child));
     },
 
     compareDocumentPosition: function(otherNode) {