This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The older shadow root should act as a parent tree scope
- Loading branch information
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
769c74c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I wonder if there's a bug here. On line 83 the test case was not updated. It seems like the correct result there would be "ts2"? In other words, I don't think the fix works in the case where a node is moved from one tree to another. In that case, the youngest ShadowRoot gets updated to have its TreeScope be the host node's tree scope.
My guess is that an additional fix is needed to reconcile with this earlier commit: ce71c44
769c74c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, I filed https://github.com/Polymer/webcomponentsjs-dev/issues/6 to track