Stores value as numeric for number input types

added numeric test
googlearchive · Feb 3, 2015 · 5a161b1 · 5a161b1
1 parent 404ecab
commit 5a161b1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/NodeBind.js b/src/NodeBind.js
@@ -173,7 +173,11 @@
     var eventType = getEventForInputType(input);
 
     function eventHandler() {
-      observable.setValue(input[property]);
+      if (property == 'value' && input.type == 'number' )
+        observable.setValue(input.valueAsNumber);
+      else
+        observable.setValue(input[property]);
+
       observable.discardChanges();
       (postEventFn || noop)(input);
       Platform.performMicrotaskCheckpoint();

diff --git a/tests/tests.js b/tests/tests.js
@@ -652,6 +652,22 @@ suite('Form Element Bindings', function() {
     radioInputCheckedMultipleForms(shadowRoot, done);
   });
 
+  test('(Number)Input.number', function(done) {
+    var input = testDiv.appendChild(document.createElement('input'));
+    testDiv.appendChild(input);
+    input.type = 'number';
+    var model = {x: 0};
+    bindings.push(input.bind('value', new PathObserver(model, 'x')));
+    input.value = "999";
+
+    then(function() {
+      dispatchEvent('input', input);
+      assert.isNumber(model.x);
+      assert.strictEqual(999, model.x);
+      done();
+    });
+  });
+
   test('Select.selectedIndex', function(done) {
     var select = testDiv.appendChild(document.createElement('select'));
     testDiv.appendChild(select);