simplify ‘unresolved’. Now to shim :unresolved, we simply remove an a…

…ttribute named unresolved.
googlearchive · Nov 15, 2013 · fdcbf08 · fdcbf08
1 parent 94288d1
commit fdcbf08
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/build.json b/build.json
@@ -1,7 +1,6 @@
 [
   "../MutationObservers/build.json",
   "src/scope.js",
-  "src/unresolved.js",
   "src/MutationObserver.js",
   "src/Observer.js",
   "src/CustomElements.js",

diff --git a/custom-elements.js b/custom-elements.js
@@ -10,7 +10,6 @@ var thisFile = 'custom-elements.js';
 var scopeName = 'CustomElements';
 var modules = [
   '../MutationObservers/mutation-observers.js',
-  'src/unresolved.js',
   'src/Observer.js',
   'src/CustomElements.js',
   'src/Parser.js',

diff --git a/src/CustomElements.js b/src/CustomElements.js
@@ -208,6 +208,8 @@ if (useNative) {
     if (definition.is) {
       element.setAttribute('is', definition.is);
     }
+    // remove 'unresolved' attr, which is a standin for :unresolved.
+    element.removeAttribute('unresolved');
     // make 'element' implement definition.prototype
     implement(element, definition);
     // flag as upgraded

diff --git a/test/js/upgrade.js b/test/js/upgrade.js
@@ -112,7 +112,16 @@ suite('upgradeElements', function() {
       assert.equal(b.test, 'ybutton');
       assert.equal(b.textContent, i);
     });
-
-
   });
+
+  // polyfill only tests
+  if (!CustomElements.useNative) {
+    test('unresolved attribute removed after upgrade', function() {
+      work.innerHTML = '<x-res unresolved>Resolved!</x-res>';
+      registerTestComponent('x-res', 'res');
+      var xres = work.firstChild;
+      assert.equal(xres.value, 'res');
+      assert.isFalse(xres.hasAttribute('unresolved'), 'unresolved is removed after upgrade');
+    });
+  }
 });