Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: For Firefox, display the extension icon in the address bar #2

Open
Ryonez opened this issue May 19, 2020 · 9 comments

Comments

@Ryonez
Copy link

Ryonez commented May 19, 2020

Basically, Firefox supports extensions showing in the address bar. A similar plugin to yours, Terms of Service; Didn’t Read, uses this and I quite like the look.

Heck, I don't care if it's by default, the option would be greatly appreciated though.

Example extension:
image

@doamatto
Copy link

@Ryonez I'll work on a PR to get this done up with the option to disable it (I agree that it looks better in the URL bar on Firefox).

@ibarakaiev
Copy link
Collaborator

ibarakaiev commented Jun 18, 2020

Hey, that’s a good suggestion. That’s actually the way it was originally implemented, but Chrome didn’t seem to support it so for simplicity (and consistency) I just left it on the right. I agree though that leaving it as a choice for users is a good idea (I would use it too!).

FYI, @doamatto, the new version that’s coming out soon will have a redesigned browser extension too. Since it’s basically going to be a new PrivacySpy, it’s probably a good idea for you not to work on this yet to avoid conflicts. I’ll probably implement it in the upcoming version.

@doamatto
Copy link

doamatto commented Jun 18, 2020

Alright; any general ETA for the new version of PrivacySpy?

@ibarakaiev ibarakaiev changed the title Feture Request: For Firefox, display the extension icon in the address bar Feature Request: For Firefox, display the extension icon in the address bar Jun 18, 2020
@ibarakaiev
Copy link
Collaborator

Tentatively, within the next week. It might be a gradual release since there are a lot of policies that are yet either incomplete or not checked. The purpose of the new version is to make the process more efficient and transparent, so in the end there won’t be delays in reviews; we feel bad for all the policies that stacked up over the past months and want to make this process simpler!

@doamatto
Copy link

doamatto commented Jun 18, 2020 via email

@Ryonez
Copy link
Author

Ryonez commented Jun 18, 2020

That’s actually the way it was originally implemented, but Chrome didn’t seem to support it

Chrome used to support it, but ended up removing the feature. Used to use it with Vivaldi, but a recent pull from the chromium removed the feature from that browser as well. Currently waiting to hear if they'll re-implement it.

Chrome is slowly pulling features people want and use, it really sucks.

@ibarakaiev
Copy link
Collaborator

Following up on this issue: apparently page actions (browser extensions when displayed in the address bar) cannot have a badge where we display a product's score. In my opinion, it defeats the purpose of having a PrivacySpy browser extension in the first place (which is intended to show the score), and so this feature won't be coming anytime soon. In the meantime, feel free to update to the new version! Currently it is only available in Firefox, but it is undergoing review in Chrome.

@Ryonez
Copy link
Author

Ryonez commented Jun 24, 2020

Can you use static images? The GNU_Terry_Pratchett extension does this:
https://github.com/TheBallOfAeolus/gnu_terry_pratchett/tree/master/data/Clacks64

@ibarakaiev
Copy link
Collaborator

I can't quite think of a way to make it look nice. I also think it is problematic to implement because page_action and browser_action are set up in manifest.json, and so having it as an option might be impossible (I am not sure though). The priority for PrivacySpy right now is to upload all legacy products , and so I probably won't get to this issue until at least after we're done with that. In the meantime, feel free to create a PR for this issue and I would be happy to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants